From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98374 invoked by alias); 4 Jul 2018 11:46:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97778 invoked by uid 89); 4 Jul 2018 11:46:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Jul 2018 11:46:34 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B75D9B798; Wed, 4 Jul 2018 11:46:32 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4303E7C5D; Wed, 4 Jul 2018 11:46:32 +0000 (UTC) Subject: Re: [RFA] Fix crash in "run" on macOS when gdb is not signed To: Tom Tromey References: <20180628180257.29883-1-tom@tromey.com> <1d40e422-08f4-30c1-de10-bd63396acb0b@redhat.com> <87o9fpodos.fsf@tromey.com> <38028d2f-ba08-fd36-6d5f-6a47455e5ccf@redhat.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <0f00199a-cb50-83e0-f0ed-6704fecd76b8@redhat.com> Date: Wed, 04 Jul 2018 11:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <38028d2f-ba08-fd36-6d5f-6a47455e5ccf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00085.txt.bz2 On 07/03/2018 03:16 PM, Pedro Alves wrote: > On 07/02/2018 04:33 PM, Tom Tromey wrote: >>>>>>> "Pedro" == Pedro Alves writes: >> >> Pedro> I'd try also with "attach", see if something else needs >> Pedro> cleaning up / unwinding. >> >> Thanks. This seemed to work fine. >> >> Pedro> If you try this with MI as is, I think gdb will output a >> Pedro> -thread-group-started notification, and then an ^error. >> Pedro> You may want to call exit_inferior instead so that >> Pedro> gdb outputs a matching -thread-group-exited. >> >> Indeed; I've changed it to use exit_inferior. >> >> Pedro> Otherwise looks fine to me. >> >> How's this? > > Looks good. Hi Tom, I happened to notice that you pushed the wrong version of the patch. Thanks, Pedro Alves