From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11231 invoked by alias); 19 Jul 2019 19:54:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11223 invoked by uid 89); 19 Jul 2019 19:54:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: mail-wr1-f68.google.com Received: from mail-wr1-f68.google.com (HELO mail-wr1-f68.google.com) (209.85.221.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Jul 2019 19:54:58 +0000 Received: by mail-wr1-f68.google.com with SMTP id p13so33303751wru.10 for ; Fri, 19 Jul 2019 12:54:57 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id c78sm44000727wmd.16.2019.07.19.12.54.55 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jul 2019 12:54:55 -0700 (PDT) Subject: Re: [PATCH 2/3] gdb: Improve output from "info types" commad To: Andrew Burgess , gdb-patches@sourceware.org References: <51913d3e-79a3-83a2-9e66-c4f62dd9feab@redhat.com> <20190719194331.GB23204@embecosm.com> From: Pedro Alves Message-ID: <0ef0b2d8-ac76-f63d-edd1-b45f8057b48a@redhat.com> Date: Fri, 19 Jul 2019 19:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190719194331.GB23204@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-07/txt/msg00477.txt.bz2 On 7/19/19 8:43 PM, Andrew Burgess wrote: > * Pedro Alves [2019-07-18 21:07:10 +0100]: > >> On 7/12/19 12:37 PM, Andrew Burgess wrote: >> I'm not immediately seeing what the C++ testcase is trying to >> test. If you replace "class" with struct, and use "typedef struct AA" >> instead of "typedef AA", isn't that code basically C code as well? >> >> Also, might it be a good idea to check the info-types.c stuff in >> C++ mode as well, to make sure we normalize C and C++ modes? >> I.e., make gdb.base/info-types.exp compile once as a C program, and >> once as a C++ program? > > I've removed the gdb.cp/info-types.{cc,exp} files, and extended the > gdb.base test to include an example of 'class'. Ah, OK, it's "class" specifically that you were looking at test. I wasn't sure. > Yes, we know > internally they are handled just like structs, but I'd like to cover > it "just in case". The gdb.base case is now compiled as C and C++. Thanks. Pedro Alves