From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41520 invoked by alias); 22 Mar 2017 11:28:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41508 invoked by uid 89); 22 Mar 2017 11:28:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy= X-HELO: mail-wm0-f46.google.com Received: from mail-wm0-f46.google.com (HELO mail-wm0-f46.google.com) (74.125.82.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Mar 2017 11:28:10 +0000 Received: by mail-wm0-f46.google.com with SMTP id t189so34780074wmt.1 for ; Wed, 22 Mar 2017 04:28:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=EFsm3XTh6UnKLC058qvyhwPShpjpVTFW7xfB4fCxRZ4=; b=A9/hP5TAeBAr5XVzn4mTVEAeSgXJkTzC8oLvTMV95UJfulxx+3pLAx0FMPPVvgjP2I 2f3v+NMS6dsGVaBaMPu/WnYzRnTeTZ0h+73oqMEG0qMNRGQ93ij2FerwWm5JqwzoWYzG QY+0RODE0cGxpX0vqNx46Kx3nokh9mlzQrFql83t+boxEwuF1VUU1ptb5iPxV+XXtGMN k600zB8NLaeXARET2REoZvVZgv9HYdY71V+73KofEzcMirDvsS8C6xwFq46V4BgiAz2j m49HiTq9CuZH4PYmoyjO/zwtjJtGfkwPp6FfeeQPXw0ROdFLYN42qOqHEAR+k8gIGEBX mzkA== X-Gm-Message-State: AFeK/H3LtsClEAw0e1EQZJ83eVOdoZk3Qu7Z9xJHZWZuzSnSrAWgapsrLhZZtvs2Mo0ggQM5 X-Received: by 10.28.88.2 with SMTP id m2mr7659400wmb.12.1490182089280; Wed, 22 Mar 2017 04:28:09 -0700 (PDT) Received: from [192.168.0.101] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id l21sm1456489wrl.59.2017.03.22.04.28.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Mar 2017 04:28:08 -0700 (PDT) Subject: Re: [PATCH v2] Remove lwp -> pid conversion in linux_nat_xfer_partial To: Simon Marchi , gdb-patches@sourceware.org References: <15f668b8e6bfe802bad5671738f7ef3b@polymtl.ca> <20170322030215.27737-1-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: <0ebe5a99-919e-cfe6-d6c6-d00ef0fa9f8f@redhat.com> Date: Wed, 22 Mar 2017 11:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170322030215.27737-1-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-03/txt/msg00391.txt.bz2 On 03/22/2017 03:02 AM, Simon Marchi wrote: > New in v2: > > - Use lwp in linux_proc_xfer_partial and linux_proc_xfer_spu. > - Updated commit message (stole some of Pedro's text) Thanks! > - if the leader exits, and goes zombie, then several files under > "/proc/" won't work, though using "/proc//task/" would. > The latter path form is also generally better for being robust in > the case TID exits and is reused in another process, much like > tkill vs tgkill. The part about TID-reuse robustness actually doesn't make sense here yet, though, since this patch is not switching to "/proc//task/". So reduce that to: - if the leader () had exited and is thus now zombie, then several files under "/proc/" won't work, while they will if you use "/proc/". Otherwise LGTM. Thanks, Pedro Alves