From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gL1BAw0ZKWoyMT8AWB0awg (envelope-from ) for ; Wed, 10 Jun 2026 03:58:05 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=XazoEwOT; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=VRbuj1TH; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=XazoEwOT; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=VRbuj1TH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id F00721E024; Wed, 10 Jun 2026 03:58:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2FC601E024 for ; Wed, 10 Jun 2026 03:58:04 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B46684BA2E12 for ; Wed, 10 Jun 2026 07:58:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B46684BA2E12 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=XazoEwOT; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=VRbuj1TH; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=XazoEwOT; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=VRbuj1TH Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id A6C424BA2E0A for ; Wed, 10 Jun 2026 07:57:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A6C424BA2E0A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A6C424BA2E0A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781078255; cv=none; b=GlQW2kwyAX557C2Q+4GMmWMEMtijDVdv4Y0oy3kSVdJnzSCKLWf0ic1F/3dkHWNPI1qTVYh0TygDsmhXuxr2cYK4qTTLIx2phKEa+4Ktb55trV0db1xM0wHGGJHM4GJ83PxzZ3XTyKFfUdwCUDiUDg+rT5YzN4/r5BJfjghU8HI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781078255; c=relaxed/simple; bh=anV9jORr7O3+VqQfeezb+NjfO4dfAGEipPSUKT6yn+s=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=ASMJvw+/zNVPcvABF7hesTyA1pcM3eh/FQw7bIOVGVIEdqN5qVSYSl3Vox6Vn9BI5FhYASNsFtHy1OBEdxG72wCN2fFegbV17bmBj2RLWhR5j1YrsFkhejp7FK5HCzAKoaK828w6n/ZdLe+/3AQEtYqOAj6pJ4eeu6UGwIPwZTs= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=XazoEwOT; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=VRbuj1TH; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=XazoEwOT; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=VRbuj1TH DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A6C424BA2E0A Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6685D758C8; Wed, 10 Jun 2026 07:57:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781078254; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hgc4uSItES1/kZ/Xcco3TR1o+s/5hkdZufeyg7QBtKE=; b=XazoEwOTsG6S88HDFjozLBXqo8QhY8c80qC6MR5mppXd3vq795Ubx+gvQEEtVq1Ff3oVvZ /kLdQ7FaLK2oH9SqIT8ji2kND2T78JXGOd/odm2snUmOP/ZALc4mQNocnCaSUS0KXKU0bF 0FyAqMZLfA5+Q6uvVkL2PXamuZuGBJs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781078254; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hgc4uSItES1/kZ/Xcco3TR1o+s/5hkdZufeyg7QBtKE=; b=VRbuj1THWNFCw5l+I2RZL3Fc/f9s6Qnyz3FYayvTQu2baQehaHxNNfGYUOMiRuay9G5VQK LPxxrbPlxZcc/0CQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=XazoEwOT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VRbuj1TH DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781078254; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hgc4uSItES1/kZ/Xcco3TR1o+s/5hkdZufeyg7QBtKE=; b=XazoEwOTsG6S88HDFjozLBXqo8QhY8c80qC6MR5mppXd3vq795Ubx+gvQEEtVq1Ff3oVvZ /kLdQ7FaLK2oH9SqIT8ji2kND2T78JXGOd/odm2snUmOP/ZALc4mQNocnCaSUS0KXKU0bF 0FyAqMZLfA5+Q6uvVkL2PXamuZuGBJs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781078254; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hgc4uSItES1/kZ/Xcco3TR1o+s/5hkdZufeyg7QBtKE=; b=VRbuj1THWNFCw5l+I2RZL3Fc/f9s6Qnyz3FYayvTQu2baQehaHxNNfGYUOMiRuay9G5VQK LPxxrbPlxZcc/0CQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4F37D779A7; Wed, 10 Jun 2026 07:57:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id otz5Ee4YKWpdXwAAD6G6ig (envelope-from ); Wed, 10 Jun 2026 07:57:34 +0000 Message-ID: <0e805260-a13a-441b-a4cf-3a6a2b703eed@suse.de> Date: Wed, 10 Jun 2026 09:57:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] [gdb/contrib] Fix KeyError in dwarf-to-dwarf-assembler.py To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260608125420.2318026-1-tdevries@suse.de> <20260608125420.2318026-2-tdevries@suse.de> <871peffxwx.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <871peffxwx.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; URIBL_BLOCKED(0.00)[suse.de:email,suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:dkim,suse.de:mid]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 6685D758C8 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/9/26 7:04 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> Fix this by special-casing DW_AT_const_value, and generating instead: > > Seems reasonable but I wonder if EXPR_ATTRIBUTE_FORMS should just be > DW_FORM_exprloc. The question is whether there are cases where DW_FORM_block* is used instead of DW_FORM_exprloc. At least our testsuite does so, for something like this: ... DW_AT_location {} DW_FORM_block1 ... Thanks, - Tom