From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122998 invoked by alias); 26 Sep 2019 14:06:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122990 invoked by uid 89); 26 Sep 2019 14:06:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (205.139.110.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Sep 2019 14:06:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1569506811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oq9ruEt9GHA0L2VXO5PxNuAO+U2vurRfeJVfc3UCOR4=; b=GGOCxh6VwAfrxEseKEJLKGsC6A9BNhJJVkWb73IIyMVDSNJprHDtoJkBcRkpYoiPwVnWqd YlyvoNXgsiKBNY64dFXkCKBCAaxyHM+xswMw0zvldroA/tYAulb7lvra0ym35Dbke+jYg2 sOvW8wKVDnG61YglvMLKpI4/K4dT3kE= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-220-BiAsUFCrPPa9r-JcfEcz5Q-1; Thu, 26 Sep 2019 10:06:47 -0400 Received: by mail-wr1-f70.google.com with SMTP id v13so983286wrq.23 for ; Thu, 26 Sep 2019 07:06:46 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id z189sm5998558wmc.25.2019.09.26.07.06.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Sep 2019 07:06:44 -0700 (PDT) Subject: Re: [RFC 15/17] Move gdb_notifier comment To: Tom Tromey , gdb-patches@sourceware.org References: <20190224165153.5062-1-tom@tromey.com> <20190224165153.5062-16-tom@tromey.com> From: Pedro Alves Message-ID: <0e6e6bc9-dcc6-4f8c-80d4-a4d13417c3ef@redhat.com> Date: Thu, 26 Sep 2019 14:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190224165153.5062-16-tom@tromey.com> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-09/txt/msg00526.txt.bz2 On 2/24/19 4:51 PM, Tom Tromey wrote: > This moves the gdb_notifier comment a bit lower in event-loop.c, to > where it belongs. >=20 > gdb/ChangeLog > 2019-02-24 Tom Tromey >=20 > * common/event-loop.c: Move comment. > --- > gdb/ChangeLog | 4 ++++ > gdb/common/event-loop.c | 22 +++++++++++----------- > 2 files changed, 15 insertions(+), 11 deletions(-) >=20 > diff --git a/gdb/common/event-loop.c b/gdb/common/event-loop.c > index 62de430f067..e761ebf27f6 100644 > --- a/gdb/common/event-loop.c > +++ b/gdb/common/event-loop.c > @@ -57,17 +57,6 @@ typedef struct file_handler > } > file_handler; >=20=20 > -/* Gdb_notifier is just a list of file descriptors gdb is interested in. > - These are the input file descriptor, and the target file > - descriptor. We have two flavors of the notifier, one for platforms > - that have the POLL function, the other for those that don't, and > - only support SELECT. Each of the elements in the gdb_notifier list is > - basically a description of what kind of events gdb is interested > - in, for each fd. */ > - > -/* As of 1999-04-30 only the input file descriptor is registered with the > - event loop. */ > - > /* Do we use poll or select ? */ > #ifdef HAVE_POLL > #define USE_POLL 1 > @@ -82,6 +71,17 @@ static unsigned char use_poll =3D USE_POLL; > #include > #endif >=20=20 > +/* Gdb_notifier is just a list of file descriptors gdb is interested in. > + These are the input file descriptor, and the target file > + descriptor. We have two flavors of the notifier, one for platforms > + that have the POLL function, the other for those that don't, and > + only support SELECT. Each of the elements in the gdb_notifier list is > + basically a description of what kind of events gdb is interested > + in, for each fd. */ > + > +/* As of 1999-04-30 only the input file descriptor is registered with the > + event loop. */ Might as well remove this stale "as of 1999-04-30" remark. We certainly register more file descriptors in the event loop nowadays. > + > static struct > { > /* Ptr to head of file handler list. */ >=20 --=20 Thanks, Pedro Alves