From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105321 invoked by alias); 28 Apr 2017 14:50:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104992 invoked by uid 89); 28 Apr 2017 14:50:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=flexibility X-HELO: mail-wm0-f46.google.com Received: from mail-wm0-f46.google.com (HELO mail-wm0-f46.google.com) (74.125.82.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Apr 2017 14:50:46 +0000 Received: by mail-wm0-f46.google.com with SMTP id u65so44388288wmu.1 for ; Fri, 28 Apr 2017 07:50:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JWp3r7aMrueD0dRMis49nbheAr798qTC7vE8SH+Fwrs=; b=Pg8P1pr50FFUHlH3MaPU68PeKts0gRi5q5IJtfSwkmUvFXzKG8u/BECmPODaA0uAYP PEporxD7bY7J3XsP8MSgN3HlxCioxleQ1mzL/EDo6P8LvR1AA6UwBimetjwuP7377AB0 9NWZdGdCJ15jZEZaXnK8+Zo6WbMaTkcxZ1T1VZM7OVeFULiWhRUOkw3XWYPcx0v4pTBX F7N4XyBxosDsQz9daU4y5rsBkgd1Xkw6TaRX9eJ1y6xdDtB1GeuN4TNIxQhHdwTttdUp vFnMidoDQi2bYz/JZWg0gmL5Fp2xLPk8XY6Vr8fLh6zfdQNn2unJ14TCWcTQGln9Hxtm OA5Q== X-Gm-Message-State: AN3rC/7SynsA1j1h3AsGbFtQzhgJPDLaP4YAI7mTb3Mi7EPjR59/IngU zobCZ/Yfh8X/Go0YM0LKmQ== X-Received: by 10.28.11.208 with SMTP id 199mr5926692wml.24.1493391046371; Fri, 28 Apr 2017 07:50:46 -0700 (PDT) Received: from ?IPv6:2a02:c7f:ae15:7800:4685:ff:fe66:9f4? ([2a02:c7f:ae15:7800:4685:ff:fe66:9f4]) by smtp.gmail.com with ESMTPSA id 187sm3760572wmt.16.2017.04.28.07.50.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Apr 2017 07:50:45 -0700 (PDT) Subject: Re: [RFA 03/10] Allow elision of some filtered frames To: Tom Tromey , gdb-patches@sourceware.org References: <20170425194113.17862-1-tom@tromey.com> <20170425194113.17862-4-tom@tromey.com> From: Phil Muldoon Message-ID: <0e522572-baa6-5376-b556-8fb3182fcf05@redhat.com> Date: Fri, 28 Apr 2017 14:50:00 -0000 MIME-Version: 1.0 In-Reply-To: <20170425194113.17862-4-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00783.txt.bz2 On 25/04/17 20:41, Tom Tromey wrote: > When a frame filter elides some frames, they are still printed by > "bt", indented a few spaces. PR backtrace/15582 notes that it would > be nice for users if elided frames could simply be dropped. This > patch adds this capability. > > ChangeLog > 2017-04-25 Tom Tromey > > PR backtrace/15582: > * stack.c (backtrace_command): Parse "elide" argument. > * python/py-framefilter.c (py_print_frame): Handle PRINT_ELIDE. > * extension.h (enum frame_filter_flags) : New > constant. > > doc/ChangeLog > 2017-04-25 Tom Tromey > > PR backtrace/15582: > * gdb.texinfo (Backtrace): Mention "elide" argument. I would have like to have seen these elide/display decisions (whether to show or not to show, whether to show with indention, etc) be made in the frame decorator itself. The decision whether a frame is actually elided or not is made there and it would allowed more flexibility if elided frames were to be displayed on a frame by frame basis. But I'm not sure if this could lead to confusing output. Anyway, it does not matter to much at this point as your patch adds the equivalent of a global override and this other, more intricate functionality, can be added later. I'm curious what you think though. Patch LGTM. Cheers Phil