Re: [PATCHv3 3/7] gdb: move display of completion results into completion_result class

Tom Tromey
2024-06-06T16:19:28Z

>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

Andrew> This commit moves the printing of the 'complete' command results out
Andrew> of the 'complete_command' function. The printing is now done in a new
Andrew> member function 'completion_result::print_matches'. At this point,
Andrew> this is entirely a refactor.

Andrew> The motivation for this refactor is how 'complete' should print the
Andrew> completion of filename arguments. In some cases the filename results
Andrew> need to have escaping added to the output. This escaping needs to be
Andrew> done immediately prior to printing the result as adding too early will
Andrew> result in multiple 'complete' results potentially being sorted
Andrew> incorrectly. See the subsequent commits for more details.

Andrew> There should be no user visible changes after this commit.

IMO it would be fine to push this one separately if you were so inclined.

Approved-By: Tom Tromey <tom@tromey.com>

Tom