Re: [PATCH 4/6] gdb: add match formatter mechanism for 'complete' command output

Eli Zaretskii
2024-03-31T05:55:49Z

> Date: Sat, 30 Mar 2024 23:49:18 +0000
> From: Lancelot SIX <lsix@lancelotsix.com>
> Cc: gdb-patches@sourceware.org
>
> > (gdb) complete file '/tmp/xx
> > file '/tmp/xxx/'
> >
> > The completion offered here is really only a partial completion, we've
> > completed up to the end of the next directory name, but, until we have
> > a filename then the completion is not finished and the trailing quote
> > should not be added.
> >
> > This would match the readline behaviour, e.g.:
> >
> > (gdb) file '/tmp/xx<TAB>
> > (gdb) file '/tmp/xxx/
> >
> > In this case readline completes the directory name, but doesn't add
> > the trailing quote character.

Btw, what readline does is not the only useful behavior. An
alternative would be this:

(gdb) file '/tmp/xx<TAB>
=> (gdb) file '/tmp/xx/'
(gdb) file '/tmp/xx/'a<TAB>
=> (gdb) file '/tmp/xx/abcd'

That is, allow to type after the closing quote, and remove the closing
quote before trying to complete. This way, the user can use
'/tmp/xx/' if that is what she needs, or continue typing and
completing if not.