From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95843 invoked by alias); 19 Nov 2018 16:58:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95827 invoked by uid 89); 19 Nov 2018 16:58:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*u:Webmail, H*u:Roundcube, H*UA:Roundcube, H*UA:1.3.6 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Nov 2018 16:58:53 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id wAJGwkEc029341 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 19 Nov 2018 11:58:51 -0500 Received: by simark.ca (Postfix, from userid 112) id DA1741E93F; Mon, 19 Nov 2018 11:58:46 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 0E56E1E481; Mon, 19 Nov 2018 11:58:46 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 19 Nov 2018 16:58:00 -0000 From: Simon Marchi To: Kevin Buettner Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH] Use std::forward_list for displaced_step_inferior_states In-Reply-To: <20181118115650.7731e488@pinnacle.lan> References: <20181112185945.24599-1-simon.marchi@ericsson.com> <20181118115650.7731e488@pinnacle.lan> Message-ID: <0dae757b7eb004cea9463deea9b807d9@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00291.txt.bz2 On 2018-11-18 13:56, Kevin Buettner wrote: > On Mon, 12 Nov 2018 19:00:03 +0000 > Simon Marchi wrote: > >> Use std::forward_list instead of manually implemented list. This >> simplifies a bit the code, especially around removal. >> >> Regtested on the buildbot. There are some failures as always, but I >> think they are unrelated. >> >> gdb/ChangeLog: >> >> * infrun.c (displaced_step_inferior_states): Change type to >> std::forward_list. >> (get_displaced_stepping_state): Adjust. >> (displaced_step_in_progress_any_inferior): Adjust. >> (add_displaced_stepping_state): Adjust. >> (remove_displaced_stepping_state): Adjust. > > LGTM. > > Kevin Thanks, I pushed it. Simon