From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id g7T8IpNYk2DrFAAAWB0awg (envelope-from ) for ; Wed, 05 May 2021 22:46:43 -0400 Received: by simark.ca (Postfix, from userid 112) id 80CD21F11C; Wed, 5 May 2021 22:46:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 931BB1E813 for ; Wed, 5 May 2021 22:46:42 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 460A13858022; Thu, 6 May 2021 02:46:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 460A13858022 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620269202; bh=QQzxzjXVsoMttYLR7rUJI9pg5TdsloQ5chWOnuA+p3k=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=bS0kULOu9khdouHDyBStfNS1iOcRHaZKSM9aoll1QwnuS5Y+XgOcG7NTY4CPm4g5b XdfDnrobaBLtCpw9JVlil/IZ3QMFaANY+AjUzYbaElBHtrcdIF2GBsAyvvKNcqfMdl ErqtElPTvVGSAxcBFRU71ke2sk0Y4xCJYtJNUZTs= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 180B03858022 for ; Thu, 6 May 2021 02:46:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 180B03858022 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1462kV7t023969 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 5 May 2021 22:46:36 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1462kV7t023969 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3E3F91E813; Wed, 5 May 2021 22:46:31 -0400 (EDT) Subject: Re: [PATCH v4 2/2] gdb/mi: add a '--force' flag to the '-break-condition' command To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: Message-ID: <0da0d85b-e5c8-7c4a-b428-0f6f7ff6e404@polymtl.ca> Date: Wed, 5 May 2021 22:46:30 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 6 May 2021 02:46:31 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > + /* There must be at least two more args: a bpnum and a condition > + expression. */ > + if (oind + 1 >= argc) > + error (_("-break-condition: Missing arguments")); I don't know what the standard is for MI commands, but it would be handy for somebody trying this by hand to say what are the expected arguments in the error message. Otherwise, LGTM, thanks! Simon