From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94025 invoked by alias); 28 May 2018 17:39:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94013 invoked by uid 89); 28 May 2018 17:39:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=speaking, afaict, AFAICT X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 May 2018 17:39:27 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E5109818BAF6; Mon, 28 May 2018 17:39:25 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D48D1C5A2; Mon, 28 May 2018 17:39:25 +0000 (UTC) Subject: Re: [RFA v2] Add "continue" response to pager To: Tom Tromey References: <20180425145200.27734-1-tom@tromey.com> <941985b1-5166-44ab-72fe-b0f62d411e2e@redhat.com> <87d0y44iyi.fsf@tromey.com> <6b0962b4-1867-0003-6310-e874ff1df2f3@redhat.com> <87in79znmh.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <0d86fa29-11aa-089a-69a8-86a0fef481ec@redhat.com> Date: Mon, 28 May 2018 18:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87in79znmh.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00742.txt.bz2 On 05/27/2018 06:14 AM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> That's fine with me. I suspect that the "---" wrapping without > Pedro> spaces might have been inspired by some Unix /usr/bin/more > Pedro> implementation, because util-linux's 'more' prints "--More-- " > Pedro> by default. > > In the end I removed the spaces. > > Pedro> commit c3f814a14336b9d395f3abad739592929e2faaa0 > Pedro> Author: Pedro Alves > Pedro> AuthorDate: Fri Jul 25 10:07:38 2014 +0100 > Pedro> Fix paginate-*.exp races > > Pedro> so it looks like the split is really no longer necessary. > > With the new text it was sufficient to just update what was expected in > this test. So I didn't end up backing out the old race fix. It seemed > pretty safe to just leave it alone. That's fine with me (though you're removing it in the gdb.python/ tests AFAICT). > commit ccd0b974d93f5a87b33fdfb38eea7ed12b00fca0 > Author: Tom Tromey > Date: Wed Apr 25 08:52:00 2018 -0600 > > Add "continue" response to pager ... > > I think this version addresses all review comments from versions 1-3. I'd suggest removing this sentence before pushing. > > Tested by the buildbot. > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index ee66a38e08..65dd1d5afd 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -82,7 +82,8 @@ if ![info exists gdb_prompt] then { > } > > # A regexp that matches the pagination prompt. > -set pagination_prompt [string_to_regexp "---Type to continue, or q to quit---"] > +set pagination_prompt \ > + "--Type to continue, q to quit, c to continue without paging--" Hmm, I'm a little surprised at the reversion to say "to continue" instead of "for more" as in the earlier suggestions: "--Type for more, q to quit, c to continue without paging--" vs "--Type to continue, q to quit, c to continue without paging--" I had suggested "for more" for two reasons: - it's shorter - avoids ambiguity in the saying "continue" twice It's not a big deal, but since you didn't comment on that, I can't be sure whether you changed it back on purpose or by accident, hence I'm speaking up. :-) Otherwise it LGTM. Thanks, Pedro Alves