From: Jan Dubiec <jdx@o2.pl>
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH v4] H8/300: sim: Fix simulator hang caused by qsort on Windows/MinGW
Date: Mon, 5 Oct 2026 01:22:07 +0200 [thread overview]
Message-ID: <0d6a8b27-8656-4f14-9043-1ffe7d1c50b7@o2.pl> (raw)
In-Reply-To: <189579af-6c0d-4643-a26c-338dc34fe8b6@simark.ca>
On 28.09.2026 16:00, Simon Marchi wrote:
> On 9/9/26 9:58 PM, Jan Dubiec wrote:
[...]
>> table is sorted �the wrong way�, i.e. when ldm appears before mov
>
> The characters around "the wrong way" seem to suffer from bad encoding.
I will repost the patch later with the quotes fixed.
> I'd suggest using a
>
> SIM_ASSERT (p1->how != p2->how)
>
> above, since we never want two entries to compare equal.
It doesn't work because the comparator doesn't use all the available
sorting keys (i.e. the members of struct h8_opcode) when sorting the
opcode table.
/J.D.
prev parent reply other threads:[~2026-10-04 23:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 1:58 Jan Dubiec
2026-09-27 8:55 ` Jan Dubiec
2026-09-28 14:00 ` Simon Marchi
2026-10-04 23:22 ` Jan Dubiec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d6a8b27-8656-4f14-9043-1ffe7d1c50b7@o2.pl \
--to=jdx@o2.pl \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox