From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-158094-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29774 invoked by alias); 9 Aug 2019 16:51:56 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 29753 invoked by uid 89); 9 Aug 2019 16:51:56 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:667, HContent-Transfer-Encoding:8bit
X-HELO: mail-wm1-f67.google.com
Received: from mail-wm1-f67.google.com (HELO mail-wm1-f67.google.com) (209.85.128.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Aug 2019 16:51:55 +0000
Received: by mail-wm1-f67.google.com with SMTP id g67so6207932wme.1        for <gdb-patches@sourceware.org>; Fri, 09 Aug 2019 09:51:54 -0700 (PDT)
Return-Path: <palves@redhat.com>
Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b])        by smtp.gmail.com with ESMTPSA id z25sm4935703wmf.38.2019.08.09.09.51.51        (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128);        Fri, 09 Aug 2019 09:51:52 -0700 (PDT)
Subject: Re: [PATCH V2] AArch64 pauth: Indicate unmasked addresses in backtrace
To: Alan Hayward <Alan.Hayward@arm.com>
References: <20190730144123.11135-1-alan.hayward@arm.com> <728af5fa-8e3d-845c-d72f-60b1d2067643@redhat.com> <F3D7A960-329A-4BDA-A251-87828CF3E459@arm.com> <474e8e87-50d4-874f-787f-ef5f5fbb6cc3@redhat.com> <A4E39580-3309-4D26-B0CE-E55EFC89E763@arm.com> <955aee56-6b01-47f6-6870-8d561a2083fc@redhat.com> <714091D9-B336-4D9C-9238-2DBC10B2E030@arm.com>
Cc: Tom Tromey <tom@tromey.com>, "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, nd <nd@arm.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <0d57bf9c-b32d-4196-3935-90faf47fe7d6@redhat.com>
Date: Fri, 09 Aug 2019 16:51:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <714091D9-B336-4D9C-9238-2DBC10B2E030@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-SW-Source: 2019-08/txt/msg00231.txt.bz2

On 8/9/19 3:46 PM, Alan Hayward wrote:

> I was thinking of the following:

Ah, I thought you meant create a "uiout->field_addr_flags(...);" method.

> 
> char *flags = gdbarch_print_pc_addr_flags(frame, pc);  /* Returns null or “PAC” or “FOO,BAR” etc */
> if (flags)
> {
>   uiout->text (“ [“);
>   uiout->field_string (“addr_flags", flags);
>   uiout->text (“]“);
> }
> 
> addr_flags can be printed by any target that wishes. And PAC only needs to be in
> AArch64 specifics.
Sounds fine to me.

Maybe return a std::string instead of a pointer to a static buffer.

Thanks,
Pedro Alves