From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79878 invoked by alias); 19 Jun 2017 09:27:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77974 invoked by uid 89); 19 Jun 2017 09:27:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Jun 2017 09:27:51 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7C16F81241 for ; Mon, 19 Jun 2017 09:27:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7C16F81241 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7C16F81241 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id EB07F17CE4; Mon, 19 Jun 2017 09:27:46 +0000 (UTC) Subject: Re: Regression: Re: [PATCH 2/6] Code cleanup: dwarf2read.c: Eliminate ::file_write To: Jan Kratochvil References: <8efc0742-1014-4fe0-6948-f40a9c5c4975@redhat.com> <1497284051-13795-2-git-send-email-palves@redhat.com> <20170618183603.GA1834@host1.jankratochvil.net> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <0d3d940c-c6d6-02df-69a0-defdd300f92f@redhat.com> Date: Mon, 19 Jun 2017 09:27:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170618183603.GA1834@host1.jankratochvil.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00498.txt.bz2 On 06/18/2017 07:36 PM, Jan Kratochvil wrote: >> @@ -23252,7 +23233,8 @@ public: >> /* Write the buffer to FILE. */ >> void file_write (FILE *file) const >> { >> - ::file_write (file, m_vec); >> + if (::fwrite (m_vec.data (), 1, m_vec.size (), file) != m_vec.size ()) >> + error (_("couldn't write data to file")); >> } > > It is a regression as one needs to multiply vector.size() by sizeof(vector[0]). > Which is also why I separated determining the memory block boundaries from > checking the write success. No it's not. The fwrite call is no longer in generic code where the element type is unknown. Here m_vec is a vector of gdb_byte, and gdb_byte is guaranteed to have sizeof == 1. Thanks, Pedro Alves