From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Phq7JJPxB2dAuwgAWB0awg (envelope-from ) for ; Thu, 10 Oct 2024 11:24:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1728573843; bh=Ck//pgsREt4qIjmXJBvgDUeuOd7CxRcyaIQm1/Gw0SQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=wdWu78pndEzVFlY23Fmm+l8oX9pYWF6H4Rtj4b/TuEcqGpcY45CYcml78HHY4JSuh qb8RizEL1P/hru84I/3zt74NogzHQQ0ViYwCukYz0jGJqgNpU/0t3G2hzpw7+BEQzI /IZeZSCTgE0K8p8bDjWpWBoF+cEMoTqYHTLH9n2I= Received: by simark.ca (Postfix, from userid 112) id 7AAC21E357; Thu, 10 Oct 2024 11:24:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=unavailable autolearn_force=no version=4.0.0 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=PC8V6ZnX; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=nwZacslY; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DDD771E355 for ; Thu, 10 Oct 2024 11:24:02 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 669F0385AC2D for ; Thu, 10 Oct 2024 15:24:02 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 6A9393857823 for ; Thu, 10 Oct 2024 15:23:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6A9393857823 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6A9393857823 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728573824; cv=none; b=cL5LY/TxRZo8IQ+ezHMmp3NKPziEyLYml7oB93+a70DP5X58xfWmdqVW7a4RUkiOepU9kmN3MRmrKPzIN7ozmmC2XO/Kt/Pd9PhpirJUnniry6qdeEv9J6PEzBqa+/Wuem0Vv9AKX9qFbgqyTWztNGgJlbEG0U8Rwa9cueckd7c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728573824; c=relaxed/simple; bh=Ck//pgsREt4qIjmXJBvgDUeuOd7CxRcyaIQm1/Gw0SQ=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=CLts0wOD7e464UbEFz5ff/H4/eprIPsgu47jIFY1odT8/1VZ8oGMfV2W5/I/1hiCKneGMRm1IVNGopomjQhJ6rHodEK89osIi0pcBTrVFVQh99w5RDf74Vns0w/wIU0wD+rKotK4iwxFh5G6y7stv3Y5sGAVed3tcdKLDj77ZJU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1728573822; bh=Ck//pgsREt4qIjmXJBvgDUeuOd7CxRcyaIQm1/Gw0SQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PC8V6ZnXGWTELlMDBzpWfwmFngL1zbeYkX3tWnVPGdbyfDs7CnCwMi/5W/reQxUuE tspgE1sqz+nvat0AV7J0E/2ju6PQeVrm0Ehg6JAijENQmsbq3mfdFr1LByD51dT3Mo EvUDAExuMzfeVQzOk3FpCz3+OCxUFWNcsyIvEsig= Received: by simark.ca (Postfix, from userid 112) id E42D41E359; Thu, 10 Oct 2024 11:23:42 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1728573821; bh=Ck//pgsREt4qIjmXJBvgDUeuOd7CxRcyaIQm1/Gw0SQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=nwZacslYLuIPtwrdysJalFPntHJn+HUDzhdfTx4cVXGo0+HYRIV50hM7zRy02JI+x GDetXM4q7ptRI1PX5ksSVG4JuIZy9z67ftRV2rHsSmiIThxFKPHOjE6R4v2vsyCx0b YBAeWFtbvhUiavALS+hSpk7cZeNd1QPQTR6cQy+E= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id CA1431E355; Thu, 10 Oct 2024 11:23:40 -0400 (EDT) Message-ID: <0d1d7cfd-9858-45e4-a7c5-f8908520cb67@simark.ca> Date: Thu, 10 Oct 2024 11:23:40 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] gdb/gdbserver: change shared set_tdesc_osabi to take gdb_osabi To: Andrew Burgess , gdb-patches@sourceware.org Cc: Luis Machado References: Content-Language: en-US From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2024-10-08 13:11, Andrew Burgess wrote: > @@ -339,7 +341,7 @@ void set_tdesc_architecture (target_desc *target_desc, > const char *tdesc_architecture_name (const struct target_desc *target_desc); > > /* Set TARGET_DESC's osabi by NAME. */ > -void set_tdesc_osabi (target_desc *target_desc, const char *name); > +void set_tdesc_osabi (target_desc *target_desc, enum gdb_osabi osabi); The comment needs to be updated. Simon