Re: [PATCH 3/4] gdb: pass target to thread_ptid_changed observable

Simon Marchi
2020-08-05T19:08:49Z

On 2020-08-05 10:50 a.m., Pedro Alves wrote:
> I don't see why we shouldn't.

I'd say because it's not worth the trouble.

>Assuming that the regcaches are empty
> like in the current patch can also fail is someone inserts some test
> before this new test that ends up filling in the regcache. I see it as
> your new test being fragile because of that, and running the
> "maint selftest" while some program is running is just a way
> to trigger it. To me, not allowing selftests while the
> program is running is just an admission that the tests
> aren't well isolated enough.
>

I think it would make more sense to require that each test cleans up
properly after itself.

But anyhow, I'll do as you suggest, I don't mind.

Simon