Re: [PATCH 0/4] Regcache fix and optimization

Simon Marchi
2020-08-06T20:27:34Z

On 2020-07-20 4:40 p.m., Simon Marchi via Gdb-patches wrote:
> The main goal of this series is patch 4, and is about changing the
> regcache storage from a linked list to a map, to make lookups and
> removals more efficient.
>
> Patches 1 and 2 are cleanups. They are not necessary, but I think they
> would be nice to have.
>
> Patch 3 addresses a potential bug I spotted while reading the code.
>
> Simon Marchi (4):
> gdb: rename regcache::current_regcache to regcache::regcaches
> gdb: move regcache::regcaches to regcache.c
> gdb: pass target to thread_ptid_changed observable
> gdb: change regcache list to be a map
>
> gdb/dwarf2/index-write.c | 1 +
> gdb/infrun.c | 78 +++++++++++-
> gdb/observable.h | 6 +-
> gdb/record-btrace.c | 1 +
> gdb/regcache.c | 259 +++++++++++++++++++++++++++++----------
> gdb/regcache.h | 7 --
> gdb/sparc64-tdep.c | 2 +-
> gdb/thread.c | 2 +-
> gdbsupport/ptid.h | 16 +++
> 9 files changed, 291 insertions(+), 81 deletions(-)
>
> --
> 2.26.2
>

I pushed the first two patches, since they had the ack of Pedro.

Simon