From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29612 invoked by alias); 27 Apr 2017 16:35:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29539 invoked by uid 89); 27 Apr 2017 16:35:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1225 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Apr 2017 16:35:37 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 021DA8E3EA; Thu, 27 Apr 2017 16:35:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 021DA8E3EA Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 021DA8E3EA Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id B7FCC93DA2; Thu, 27 Apr 2017 16:35:28 +0000 (UTC) Subject: Re: [PATCH v2 2/8] Python: Fix exception handling in py-record-btrace.c To: Tim Wiederhake , gdb-patches@sourceware.org References: <1492771786-26372-1-git-send-email-tim.wiederhake@intel.com> <1492771786-26372-3-git-send-email-tim.wiederhake@intel.com> Cc: markus.t.metzger@intel.com, brobecker@adacore.com, qiyaoltc@gmail.com From: Pedro Alves Message-ID: <0ceec05a-2d2c-6bed-ed88-064d3c369e8d@redhat.com> Date: Thu, 27 Apr 2017 16:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1492771786-26372-3-git-send-email-tim.wiederhake@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00744.txt.bz2 On 04/21/2017 11:49 AM, Tim Wiederhake wrote: > GDB_PY_HANDLE_EXCEPTION does not handle all exceptions. Replace with call to > gdbpy_convert_exception. This makes no sense to me. Here's the definition: /* Use this after a TRY_EXCEPT to throw the appropriate Python exception. */ #define GDB_PY_HANDLE_EXCEPTION(Exception) \ do { \ if (Exception.reason < 0) \ { \ gdbpy_convert_exception (Exception); \ return NULL; \ } \ } while (0) That definitely handles all exceptions. "reason" is never positive. I could see > @@ -891,14 +898,17 @@ recpy_bt_goto (PyObject *self, PyObject *args) > target_goto_record_end (); > else > target_goto_record (obj->number); > + > + Py_INCREF (Py_None); > + ret = Py_None; > } > CATCH (except, RETURN_MASK_ALL) > { > - GDB_PY_HANDLE_EXCEPTION (except); > + gdbpy_convert_exception (except); > } > END_CATCH > > - Py_RETURN_NONE; > + return ret; > } this particular change making sense, but for a completely different reason -- GDB_PY_HANDLE_EXCEPTION returns NULL and here you seem to want to return a Py_None with a reference. But that should be split to its own patch with its own rationale. Thanks, Pedro Alves