From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97285 invoked by alias); 6 Sep 2017 15:25:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97266 invoked by uid 89); 6 Sep 2017 15:25:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1622 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Sep 2017 15:25:06 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DB346C0587EF; Wed, 6 Sep 2017 15:25:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DB346C0587EF Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0981F4F6DB; Wed, 6 Sep 2017 15:25:03 +0000 (UTC) Subject: Re: [PATCH] Add selftests run filtering To: Simon Marchi , gdb-patches@sourceware.org References: <1504612227-7159-1-git-send-email-simon.marchi@ericsson.com> From: Pedro Alves Message-ID: <0cc25dd0-4311-28e8-f0ca-443719354bed@redhat.com> Date: Wed, 06 Sep 2017 15:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1504612227-7159-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00151.txt.bz2 Sounds useful. Patch looks fine to me. Nits and comments below. I wonder whether we'll want to be able to do select tests with e.g., a regexp instead of exact matching. If we do, then the std::vector->std::map change would seem pointless. Do you plan on adding some command to list the existing tests? On 09/05/2017 12:50 PM, Simon Marchi wrote: > static void > maintenance_selftest (char *args, int from_tty) > { > - selftests::run_tests (); > + selftests::selftests_results results_noarch = selftests::run_tests (args); > + selftests::selftests_results results_arch = selftests::run_tests_with_arch (args); Line too long? You could also shorten "selftests_results" to e.g., "test_results", since the type is already in the "selftests" namespace. > + printf_filtered (_("Ran %d unit tests, %d failed\n"), > + results_noarch.ran + results_arch.ran, > + results_noarch.failed + results_arch.failed); Wonder whether it'd make sense to implement operator+= for selftests_results so that you'd write: selftests::selftests_results results = selftests::run_tests (args); results += selftests::run_tests_with_arch (args); // etc. printf_filtered (_("Ran %d unit tests, %d failed\n"), results.ran, results.failed); > _initialize_findvar (void) > { > #if GDB_SELF_TEST > - selftests::register_test (selftests::findvar_tests::copy_integer_to_size_test); > + selftests::register_test ( > + "copy_integer_to_size", > + selftests::findvar_tests::copy_integer_to_size_test); > #endif In GNU style it's much more common to break the line before "(", not after. Thanks, Pedro Alves