From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gOhmNF7o2GcrcRMAWB0awg (envelope-from ) for ; Mon, 17 Mar 2025 23:28:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1742268510; bh=HupSYtN95ls55/SIJxo34BB2sEcAUXv1WULOUUqgSuA=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=jBF5IZVVw4P4zhC4t4RqgrKR8jACgfp1Beug7jChP6VBWoFiif7hKK7lnbWhXaEJl fz0YyadyPwmTEE+uW3vU6gOgjoQVhAShvPtS4/GGIVDNTz270pmcn6JrWseFXjxOes feiEyHs4GYcY/Ik/nymmh5j4OKUo6JIYm1CfUCpc= Received: by simark.ca (Postfix, from userid 112) id CC3601E100; Mon, 17 Mar 2025 23:28:30 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=WE5eB7sn; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=WE5eB7sn; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3CA081E05C for ; Mon, 17 Mar 2025 23:28:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E5C773858C98 for ; Tue, 18 Mar 2025 03:28:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E5C773858C98 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=WE5eB7sn; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=WE5eB7sn Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 30C1B3858D29 for ; Tue, 18 Mar 2025 03:28:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 30C1B3858D29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 30C1B3858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742268480; cv=none; b=Zm2hcVT7iRzmYBqePuID1Dc4Fs40zH8NFykMkykWnSuZdEcueobUddJ4Ri96cz3d+oJeeVzIpljig4j9oM23kJMC7Lv8ZhBOZBzZDpOj6wQDJ9hUynSvpFsuBcGEzb0K7L5k+1uRU+M6T+L+/lutYDxigAYrgDrHGbIuda5OBEM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742268480; c=relaxed/simple; bh=HupSYtN95ls55/SIJxo34BB2sEcAUXv1WULOUUqgSuA=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=A/U+VGVFm6liZjUH1FRVOGwgPqCcanRUphCKEoVuVVzZ8UvrAzamGpeQz9m83+O9vAw0Y0jVOq4BW//UKUEs8FXMQ6jCkNipVgDBmDr89YsSM+RSGrGzlOEA2j6mByk5ljclW8FFTl6OFDS5a4IRTB1zGRipB0bBmZKSjTFRNT8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 30C1B3858D29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1742268479; bh=HupSYtN95ls55/SIJxo34BB2sEcAUXv1WULOUUqgSuA=; h=Date:Subject:To:References:From:In-Reply-To:From; b=WE5eB7snxfri2M8YP/WziEY0TJ84Nzt3/kjhfqC2LTrjYoZCGfgOZz3ETyC9YPtZ3 +DE9MSzqC8X6Ow+/pzS0F5Gq96aH97QZFq+wDnlbhHEmdFIxpFXYAAwhi7uecCKsKk NXfA9xaQ6Ixj7xLO5rDwYnnLBPh2cGCGtr1kxsrQ= Received: by simark.ca (Postfix, from userid 112) id BA8F31E10E; Mon, 17 Mar 2025 23:27:59 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1742268479; bh=HupSYtN95ls55/SIJxo34BB2sEcAUXv1WULOUUqgSuA=; h=Date:Subject:To:References:From:In-Reply-To:From; b=WE5eB7snxfri2M8YP/WziEY0TJ84Nzt3/kjhfqC2LTrjYoZCGfgOZz3ETyC9YPtZ3 +DE9MSzqC8X6Ow+/pzS0F5Gq96aH97QZFq+wDnlbhHEmdFIxpFXYAAwhi7uecCKsKk NXfA9xaQ6Ixj7xLO5rDwYnnLBPh2cGCGtr1kxsrQ= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id F0B381E05C; Mon, 17 Mar 2025 23:27:58 -0400 (EDT) Message-ID: <0cbb4330-b9b1-44d2-b0bc-53e1f25044f5@simark.ca> Date: Mon, 17 Mar 2025 23:27:58 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/19] Convert std::unordered_{set,map} to gdb implementations To: Tom Tromey , gdb-patches@sourceware.org References: <20250317-replace-std-stuff-v1-0-7ba4ee88e218@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20250317-replace-std-stuff-v1-0-7ba4ee88e218@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-03-17 22:14, Tom Tromey wrote: > This changes a number of uses of std::unordered_{set,map} to the gdb:: > equivalents. > > Not every spot is converted. I only changed the ones that I felt I > could reasonably test; or in one or two cases, I left one alone since > it will be addressed some other way. > > I've also got some similar patches to reduce the use of htab_t. I'll > send that as a separate series sometime later. > > Regression tested on x86-64 Fedora 40. > > Signed-off-by: Tom Tromey Modulo the minor questions/comments I sent, this LGTM. Most of it is 1:1 replacement, so it's relatively trivial. Approved-By: Simon Marchi Thanks, Simon