From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2956 invoked by alias); 29 Apr 2016 12:46:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2890 invoked by uid 89); 29 Apr 2016 12:46:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=agent X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 29 Apr 2016 12:46:26 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7BE173B9; Fri, 29 Apr 2016 12:46:25 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3TCkNUg009071; Fri, 29 Apr 2016 08:46:24 -0400 Subject: Re: [PATCH] ftrace: Fix gdbserver crash when doing tstatus after detach or process exit To: Simon Marchi , gdb-patches@sourceware.org References: <1459344024-2260-1-git-send-email-simon.marchi@ericsson.com> From: Pedro Alves Message-ID: <0c7c5447-633e-496a-bd1a-0bd9a231fcfd@redhat.com> Date: Fri, 29 Apr 2016 12:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1459344024-2260-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00652.txt.bz2 On 03/30/2016 02:20 PM, Simon Marchi wrote: > Instead, the solution I chose is to clear the > all_agent_symbols_looked_up flag whenever we have no more current thread > (process exit or detach). I am not 100% sure it's correct, as there > might be valid situations I don't know about where the agent is loaded > but current_thread == NULL, so please correct me if I'm wrong. There definitely are. current_thread ends up set to NULL if the current _thread_ exits, but the process is still around, with other threads. See: https://sourceware.org/ml/gdb-patches/2015-08/msg00152.html Thanks, Pedro Alves