Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@efficios.com>
To: "Joos, Christina" <christina.joos@intel.com>,
	Andrew Burgess <aburgess@redhat.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb: use NT_386_TLS regset to access TLS GDT entries on i386 Linux
Date: Wed, 30 Sep 2026 10:16:46 -0400	[thread overview]
Message-ID: <0c4c741d-6c5c-44fb-ab97-68f66be36ce3@efficios.com> (raw)
In-Reply-To: <SN7PR11MB76381395372B8F9669C84864898B2@SN7PR11MB7638.namprd11.prod.outlook.com>



On 2026-09-30 10:13, Joos, Christina wrote:
> I verified these configs for gdb.arch/i386-tls-regs.exp:
> 
> - x86-64 kernel, 64-bit GDB, native
> - x86-64 kernel, 64-bit GDB, gdbserver
> - x86-64 kernel, 32-bit GDB, native
> - x86-64 kernel, 32-bit GDB, gdbserver
> 
> But I did save myself the time of compiling an i386 kernel this time.

For the record, I used machine cfarm26 on the compile farm, much easier
than building my own!

>>> I plan to look at this in a few hours, but since Andrew has already approved it,
>> it's of course fine with me if you go ahead.
>>> This is probably a bit urgent.
>>
>> You can take the time to review it, it won't make a difference whether we
>> merge this today or later this week.
>>
>>> Since x32 is mentioned here, just FYI, in case you haven't seen it:
>>> https://www.phoronix.com/news/Linux-x32-ABI-2026
>>
>> Indeed, I just looked into it because someone mentioned it in the bug.
> 
> Thanks a lot for this patch. I have nothing to add; it looks all good to me.
> 
> I also learned quite a lot while looking at this.
> 
> Approved-By: Christina Joos <christina.joos@intel.com>

Thanks for the review, I also learned a lot from this!

I'll push the patch momentarily.

Simon

  reply	other threads:[~2026-09-30 14:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 17:21 Simon Marchi
2026-09-29  9:37 ` Andrew Burgess
2026-09-29 11:38   ` Joos, Christina
2026-09-29 14:22     ` Simon Marchi
2026-09-30 14:13       ` Joos, Christina
2026-09-30 14:16         ` Simon Marchi [this message]
2026-09-30 10:01   ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c4c741d-6c5c-44fb-ab97-68f66be36ce3@efficios.com \
    --to=simon.marchi@efficios.com \
    --cc=aburgess@redhat.com \
    --cc=christina.joos@intel.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox