From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55831 invoked by alias); 24 Nov 2016 18:41:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55822 invoked by uid 89); 24 Nov 2016 18:41:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD,SPF_HELO_PASS,UNWANTED_LANGUAGE_BODY autolearn=ham version=3.3.2 spammy=uiout, *uiout, ui_file, ui_out_data X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 Nov 2016 18:41:00 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 24FF93DEEB; Thu, 24 Nov 2016 18:40:59 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAOIevrg020823; Thu, 24 Nov 2016 13:40:58 -0500 Subject: Re: [PATCH 11/22] Use std::vector for cli_ui_out_data::streams To: Simon Marchi , gdb-patches@sourceware.org References: <20161124152428.24725-1-simon.marchi@polymtl.ca> <20161124152710.25007-11-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: <0be7cb40-1dc5-68d5-d2b4-1a4e5d47dd49@redhat.com> Date: Thu, 24 Nov 2016 18:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161124152710.25007-11-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00775.txt.bz2 On 11/24/2016 03:26 PM, Simon Marchi wrote: > @@ -406,13 +404,14 @@ cli_out_set_stream (struct ui_out *uiout, struct ui_file *stream) > { > cli_out_data *data = (cli_out_data *) ui_out_data (uiout); > struct ui_file *old; > - > - old = VEC_pop (ui_filep, data->streams); > - VEC_quick_push (ui_filep, data->streams, stream); > + > + old = data->streams.back (); > + data->streams.pop_back (); > + data->streams.push_back (stream); back() returns a reference, so this pop/push can be just: data->streams.back () = stream; Thanks, Pedro Alves