From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 0F952398305A for ; Fri, 15 May 2020 15:46:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0F952398305A Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-IxcWKE8tPbuZ5cehtWbPaA-1; Fri, 15 May 2020 11:46:12 -0400 X-MC-Unique: IxcWKE8tPbuZ5cehtWbPaA-1 Received: by mail-wm1-f71.google.com with SMTP id e15so5586081wme.1 for ; Fri, 15 May 2020 08:46:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2AomwiFaVI/NkKlzKj9z1LBUPeegksfUNoQ6X4ejuyw=; b=iZ8//MOev3xCNcxNLFYl6qkN9Klj3BZdIEPYU+LZibV8KYqIrGJPWMncF7sgSXNrnt CZsCNpQ1ARIZK+QKhAKUAYKy5YmB3TP9JrZskvp1HKeiE/Gk4fa2xTo2LfdjM6yDVNVm RgXEEXu4pBq1qqho7+ep10K/rfRPlmD7a7rZ3l+YVyqra7boQfeRKkREBXuN75Ci389W PGoXr+2wNFSTwvUzqLNnDgeu2dihur+mds2aEHNCB3gJ3hRaFL52/ZFU9YmaM1BS/FrQ sJ5DUL/VdnMHnAYO+cx4c8c15e8KxOlfYHyFDOY//s4zRWsGxyyntP/UvOXtbL2+z0VK aL2A== X-Gm-Message-State: AOAM533eRKvoXBLIXl880CyPNbY0qPDYv2+ail/q5VRZ00H0gdvgHdn/ Olu6SHVTevVAcf5dXpDy+IlymbS2iNIi6c0LyDE2TkfdhnyhWWrBimjq4VbS6EUyWxELCD6X3qb wON+PWdgycp8VmlBZI8GFRg== X-Received: by 2002:a5d:4e0a:: with SMTP id p10mr4792922wrt.215.1589557571044; Fri, 15 May 2020 08:46:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymIEeI/nL2zjVMnvwQ6VkJP9aQxoD5kONnZ538xBVcAWHO1PU7WTBKAADTDZzUlzpnrSZqpg== X-Received: by 2002:a5d:4e0a:: with SMTP id p10mr4792908wrt.215.1589557570841; Fri, 15 May 2020 08:46:10 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id b145sm4491819wme.41.2020.05.15.08.46.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2020 08:46:10 -0700 (PDT) Subject: Re: [PATCH v8 6/6] gdb/infrun: handle already-exited threads when attempting to stop To: Tom de Vries , "Aktemur, Tankut Baris" , "gdb-patches@sourceware.org" References: <20200513205338.14233-1-palves@redhat.com> <20200513205338.14233-7-palves@redhat.com> <0d00b418-3c5f-4a8c-12dd-eeee8ad12b6b@suse.de> <4ade3da1-a8cd-ba29-80da-f5e742f7b52a@palves.net> <7d7a056c-63cb-1865-b8ab-027840ac15bc@redhat.com> From: Pedro Alves Message-ID: <0bd64ab2-e736-2dbc-5fc2-99b32a44d670@redhat.com> Date: Fri, 15 May 2020 16:46:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2020 15:46:17 -0000 On 5/15/20 3:16 PM, Tom de Vries wrote: > With attached patch, we have: > ... > Running src/gdb/testsuite/gdb.ada/info_auto_lang.exp ... > WARNING: info_auto_lang.exp defined global array type_in_c > WARNING: info_auto_lang.exp defined global array rbreak_func_in_ada > WARNING: info_auto_lang.exp defined global array var_in_c > WARNING: info_auto_lang.exp defined global array func_in_c > WARNING: info_auto_lang.exp defined global array func_in_ada > WARNING: info_auto_lang.exp defined global array type_in_ada > WARNING: info_auto_lang.exp defined global array var_in_ada > WARNING: info_auto_lang.exp defined global array rbreak_func_in_c > ... Seems like a good thing to have to me. > > +# Returns 1 if __VAR is a global array. > + > +proc global_array_exists { __var } { ... > +proc global_unset { __var } { Curious -- is there a reason for the underscores? > +proc check_global_vars { } { > + global gdb_global_vars > + set vars [info globals] > + set skip [list "expect_out" "spawn_out"] > + foreach var $vars { > + set found [lsearch -exact $gdb_global_vars $var] > + if { $found != -1 } { > + # Already present Missing period. > + continue > + } > + set found [lsearch -exact $skip $var] > + if { $found != -1 } { > + continue > + } > + if { ![global_array_exists $var] } { > + continue > + } > + > + global gdb_test_file_name > + warning "$gdb_test_file_name.exp defined global array $var" Tabs vs spaces. Thanks, Pedro Alves