Re: [PATCH v2] PowerPC: Add support for Dense Math registers (RFC02653)

[Ulrich Weigand <Ulrich.Weigand@de.ibm.com>]

Abhay Kandpal <abhay@linux.ibm.com> wrote:

>gdb/
>	* arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_DMRREGSET):
Define.
>	(ppc_linux_features): Add isa32 field.
>	(ppc_linux_no_features): Initialize isa32 to false.
>	* arch/ppc-linux-common.c (ppc_linux_match_description):
Return
>	the ISA 3.X target description when isa32 is set.
>	* arch/ppc-linux-tdesc.h (tdesc_powerpc_isa32_vsx32l)
>	(tdesc_powerpc_isa32_vsx64l): Declare.
>	* features/Makefile: Add powerpc-isa32-vsx32l and
>	powerpc-isa32-vsx64l entries.
>	* features/rs6000/power-dmr.xml: New file.
>	* features/rs6000/powerpc-isa32-vsx32l.xml: New file.
>	* features/rs6000/powerpc-isa32-vsx64l.xml: New file.
>	* features/rs6000/powerpc-isa32-vsx32l.c: New generated file.
>	* features/rs6000/powerpc-isa32-vsx64l.c: New generated file.
>	* regformats/rs6000/powerpc-isa32-vsx32l.dat: New generated
file.
>	* regformats/rs6000/powerpc-isa32-vsx64l.dat: New generated
file.
>	* nat/ppc-linux.h (PPC_FEATURE2_DMF): Define if not already
>	defined.
>	* ppc-linux-nat.c (fetch_register, fetch_ppc_registers): Fetch
the
>	dmr regset.
>	(store_register, store_ppc_registers): Store the dmr regset.
>	(ppc_linux_nat_target::read_description): Detect Dense Math
>	availability and set the isa32 field in the features struct.
>	* ppc-linux-tdep.c (ppc32_regmap_dmr, ppc32_linux_dmrregset):
>	New globals.
>	(ppc_linux_iterate_over_regset_sections): Call back with the
dmr
>	regset.
>	* ppc-linux-tdep.h (ppc32_linux_dmrregset): Declare.
>	* ppc-tdep.h (struct ppc_gdbarch_tdep) <ppc_dmr0_regnum>: New
>	field.
>	(enum): <PPC_DMR0_REGNUM> through <PPC_DMR7_REGNUM>: New enum
>	values.
>	(PPC_IS_DMR_REGNUM): Define.
>	* rs6000-tdep.c (rs6000_gdbarch_init): Look for and validate
the
>	dmr feature.
>
>gdbserver/
>	* configure.srv (powerpc*-*-linux*): Add rs6000/power-dmr.xml,
>	powerpc-isa32-vsx32l.o and powerpc-isa32-vsx64l.o.
>	* linux-ppc-low.cc (ppc_fill_dmrregset, ppc_store_dmrregset):
>	New functions.
>	(ppc_regsets): Add entry for dmr regset.
>	(ppc_target::low_arch_setup): Detect Dense Math availability
and
>	set isa32 in the features struct.  Set size for dmr regset.
>	(ppc_target::get_ipa_tdesc_idx): Return PPC_TDESC_ISA32_VSX
for
>	the ISA 3.X target description.
>	* linux-ppc-ipa.cc (ppc_get_ipa_tdesc): Handle
PPC_TDESC_ISA32_VSX.
>	* linux-ppc-tdesc-init.h (PPC_TDESC_ISA32_VSX): New enum
value.
>	(init_registers_powerpc_isa32_vsx32l): Declare.
>	(init_registers_powerpc_isa32_vsx64l): Declare.


This version is OK.

Thanks,
Ulrich