Re: [RFA 4/4] Remove interp_name

[Pedro Alves <palves@redhat.com>]

On 04/30/2018 06:12 AM, Tom Tromey wrote:
> This removes the interp_name function.  It is only used a few spots --
> one of which was only calling it on "this".  It's simpler to remove
> it; and should class interp become opaque in the future, it will be
> just as easy to update the two remaining spots to use an accessor.

Yeah, IIRC, it used to be opaque until I C++ified it.  Not seeing
a need to go back.

> 
> ChangeLog
> 2018-04-29  Tom Tromey  <tom@tromey.com>
> 
> 	* interps.c (interp_name): Remove.
> 	* mi/mi-interp.c (mi_interp::init): Update.
> 	* interps.h (interp_name): Remove.
> 	(~scoped_restore_interp): Update.
> 	* tui/tui.c (tui_enable): Update.

> diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c
> index 7943a61676..9e2520b4fc 100644
> --- a/gdb/tui/tui.c
> +++ b/gdb/tui/tui.c
> @@ -415,7 +415,7 @@ tui_enable (void)
>  
>        /* If the top level interpreter is not the console/tui (e.g.,
>  	 MI), enabling curses will certainly lose.  */
> -      interp = interp_name (top_level_interpreter ());
> +      interp = top_level_interpreter ()->name;
>        if (strcmp (interp, INTERP_TUI) != 0)
>  	error (_("Cannot enable the TUI when the interpreter is '%s'"), interp);

Not sure.  The name is supposedly read-only, which would
suggest renaming the field to m_name and adding a name()
getter.  WDYT?

Thanks,
Pedro Alves