From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 1T2wACfccmEFfgAAWB0awg (envelope-from ) for ; Fri, 22 Oct 2021 11:43:35 -0400 Received: by simark.ca (Postfix, from userid 112) id E60FA1F0BD; Fri, 22 Oct 2021 11:43:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3CDE01E79C for ; Fri, 22 Oct 2021 11:43:34 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9EDF4385781F for ; Fri, 22 Oct 2021 15:43:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9EDF4385781F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1634917413; bh=Ny9qnJxJ9NHsIou+nilWoo9ITekmwPQBpj/KawQ4Ckk=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=f4fIU2qQkw27r4K2C5Sx1r4ivSuWhRv8U3qOBSPDBNyi8B1Qu+kWT9IwriIUvORaY cOZNVPzqbQEI498WQRbg6rtPm86/9VXM3JVQ95nUnJKyo60GyCGN2qSnbMyDxXvHxs h6aR1KPekhL/+p3+wPQQLenamEo8bzGSyJ+IATs8= Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 67CEE3858416 for ; Fri, 22 Oct 2021 15:43:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 67CEE3858416 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8BA8B1FD3D; Fri, 22 Oct 2021 15:43:14 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 761CB13CDE; Fri, 22 Oct 2021 15:43:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4md5GxLccmFCHQAAMHmgww (envelope-from ); Fri, 22 Oct 2021 15:43:14 +0000 Subject: Re: [PATCH][gdb/testsuite] Fix FAILs in gdb.mi/mi-breakpoint-changed.exp To: Simon Marchi , gdb-patches@sourceware.org References: <20211005144645.GA29297@delia> <087bd7be-bb4e-aca7-b040-169be3632114@polymtl.ca> Message-ID: <0b3b6bde-6328-b708-4ec9-362f2852f2e3@suse.de> Date: Fri, 22 Oct 2021 17:43:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <087bd7be-bb4e-aca7-b040-169be3632114@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 10/22/21 2:55 PM, Simon Marchi wrote: > > > On 2021-10-05 10:46, Tom de Vries via Gdb-patches wrote: >> Hi, >> >> Since commit e36788d1354 "[gdb/testsuite] Fix handling of nr_args < 3 in >> mi_gdb_test" we run into: >> ... >> PASS: gdb.mi/mi-breakpoint-changed.exp: test_auto_disable: mi runto main >> Expecting: ^(-break-insert -f pendfunc1[^M >> ]+)?((&.*)*.*~"Breakpoint 2 at.*\\n".*=breakpoint-created,\ >> bkpt=\{number="2",type="breakpoint".*\}.*\n\^done[^M >> ]+[(]gdb[)] ^M >> [ ]*) >> -break-insert -f pendfunc1^M >> ^done,bkpt={number="2",type="breakpoint",disp="keep",enabled="y",\ >> addr="0x00007ffff7bd559e",func="pendfunc1",\ >> file="gdb/testsuite/gdb.mi/pendshr1.c",\ >> fullname="gdb/testsuite/gdb.mi/pendshr1.c",line="21",thread-groups=["i1"],\ >> times="0",original-location="pendfunc1"}^M >> (gdb) ^M >> FAIL: gdb.mi/mi-breakpoint-changed.exp: test_auto_disable: \ >> -break-insert -f pendfunc1 (unexpected output) >> ... >> >> The regexp expects a breakpoint-created event, but that's actually suppressed >> by the command: >> ... >> DEF_MI_CMD_MI_1 ("break-insert", mi_cmd_break_insert, >> &mi_suppress_notification.breakpoint), >> ... >> >> Fix this by updating the regexp. >> >> Likewise for the following: >> ... >> PASS: gdb.mi/mi-breakpoint-changed.exp: test_auto_disable: \ >> -break-insert -f pendfunc1 >> Expecting: ^(-break-enable count 1 2[^M >> ]+)?(=breakpoint-modified,\ >> bkpt=\{number="2",type="breakpoint",disp="dis",enabled="y".*\}.*\n\^done[^M >> ]+[(]gdb[)] ^M >> [ ]*) >> -break-enable count 1 2^M >> ^done^M >> (gdb) ^M >> FAIL: gdb.mi/mi-breakpoint-changed.exp: test_auto_disable: \ >> -break-enable count 1 2 (unexpected out\ >> put) >> ... >> >> Tested on x86_64-linux. >> >> Any comments? > > So, the test used to wrongfully pass because mi_gdb_test was broken, and > fixing mi_gdb_test exposed that the test is wrong? Yes, that's my understanding. > If so, this looks > good to me. Thanks for the review, committed. - Tom