From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id S5kOFUVgLWUXfy8AWB0awg (envelope-from ) for ; Mon, 16 Oct 2023 12:09:41 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=mtXj9cVy; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 45F581E0C1; Mon, 16 Oct 2023 12:09:41 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 32BB61E00F for ; Mon, 16 Oct 2023 12:09:39 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2D0DF3858004 for ; Mon, 16 Oct 2023 16:09:38 +0000 (GMT) Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id 6EFA33858C33 for ; Mon, 16 Oct 2023 16:09:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6EFA33858C33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6EFA33858C33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697472567; cv=none; b=nQ6jDI4cNUn1ovJGb8t1uvBilrYkgQxfc0OMQb6vNkbFzHU2jJTxfqKCvFgXH7p8wUZX0i+asYr0SUpgxf7G4CyONPfXfvqgGqULpRcSD56WrduWMGm074dBgX6s5NVJcJad/fVSaF9BQdTvlraQVw8YGizFfFi0GmIuV947WVQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697472567; c=relaxed/simple; bh=RuCrBOhslDp8zpjqV71B0AnSVwDbtZR4Sr1wSxycI8Q=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=xm62XR13l72xr5aogt7s4tq4PzYrx2D+COP+qrOjsfTrtZ83MbgD6I6tsbB7dvjHLNSfkABDGkd+XFo8zFi9n2KHc04ozhDyAnmDORjo3weC49ku2UC5hIVO3uA1NPn8kerUxy2TbEveBChlswqxITXhDkIqD5c6e+BjV1ogO34= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-5079f9ec8d9so3191832e87.0 for ; Mon, 16 Oct 2023 09:09:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697472563; x=1698077363; darn=sourceware.org; h=in-reply-to:from:cc:references:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=4jvxyth+AQ59w0olMV3T9kp8l0o4Bampclzv142UFgk=; b=mtXj9cVyqZkk2VZtcmlF5aiM0HueyeEteqPJlLAPiq7soWGZUYYvTz78G7uOZEOe9I Cz/D5DV4Nbhm9AMiXJegmi6Q/uUGa6ZEuin0njjtYlqlfuJ7+GMWEdaMFONfZOR97RMV 9YOq/pONRsJomeqIIrrU+4iX/kfcHSFfGsImvK2QPhe6Vcmhh+VAsByP1WSO0hkBeoZl AutZQLN6eSBo1cbag+8brPSAuJNcXr11E16VGX4hg21RFZeqlKdXxBmk/IYYMP2gndwS Lnq/3ssLbMPahFMNnKAdVeVJ23x0p+/4fIGIqm8RHnqyG+umU0zzMhI1Jx+fd75qIJ4e uc8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697472563; x=1698077363; h=in-reply-to:from:cc:references:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4jvxyth+AQ59w0olMV3T9kp8l0o4Bampclzv142UFgk=; b=nrxDlL9ua2QiEykjW0zqd0sAcWYOGXVTPWZIgzeESCkt5Si8RTgp3Y7EX3UKqmlLEA V1nJre9oJMDy3aZKcQ779pG81xirh0/QTpWLE1i5pmY71k0EM36mepEjg/B8hA4GHoLO hTeGKvYyVpoQLDHH+E/yD/k2vL5B7/oNi7ocNpRxPXUiJCONKa5tbgbj/1DyNaX6Oc7o qndtwKZt86RRgZ9BgX3TjNob8CSYY41/bTsfSYrAm+mjsE/LOGn4sXYjL4BH+k3kEhLA /Mqtjw4fDUA1K13cZ03+C+7MqNwQtjzhOTNA0y1xuWgAeQwjKELMgSvdIGZN0LZe65lr sAiw== X-Gm-Message-State: AOJu0YxgSoShSBocwhUK4Vv3j05KYbxpVAraif8F+B13xA+k8jB5wUab 4A6YKsJJqGrnscuLzkl10R+kS6uUd7sb+g== X-Google-Smtp-Source: AGHT+IHdEbYVt0+LfdS46TMGiPb0WJbuV/QO/ZRJzWN5mZsFhUVNyFS24ZDn6Lz0kG7GrVdgc7YC9Q== X-Received: by 2002:ac2:442c:0:b0:4fe:8ba8:1a8b with SMTP id w12-20020ac2442c000000b004fe8ba81a8bmr5010733lfl.7.1697472563188; Mon, 16 Oct 2023 09:09:23 -0700 (PDT) Received: from ?IPV6:2001:2044:c7:5500:e269:21d7:2536:bc4a? ([2001:2044:c7:5500:e269:21d7:2536:bc4a]) by smtp.gmail.com with ESMTPSA id c2-20020ac25f62000000b0050420791528sm16377lfc.293.2023.10.16.09.09.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Oct 2023 09:09:22 -0700 (PDT) Content-Type: multipart/alternative; boundary="------------oOmosafgS3D5pfSYJYxWY2A9" Message-ID: <0ae26595-113d-408d-8144-bbcbd8f427fd@gmail.com> Date: Mon, 16 Oct 2023 18:09:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] [gdb/python]: Add StepEndedEvent (simplifies DAP) Content-Language: en-US To: gdb-patches@sourceware.org References: <20231016115026.133574-1-simon.farre.cx@gmail.com> <8734yahaqx.fsf@redhat.com> Cc: Andrew Burgess From: Simon Farre In-Reply-To: <8734yahaqx.fsf@redhat.com> X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org This is a multi-part message in MIME format. --------------oOmosafgS3D5pfSYJYxWY2A9 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > This will definitely need some tests writing for it. It might be > possible to just add some additional cases to gdb.python/py-events.exp > to cover this new functionality. I'll get to that. I'll probably add a completely new test, because I find the Tcl test suites more or less unintelligible, so altering them becomes almost unreasonably difficult to modify and still be sure that the test still tests what it was meant to.If that's ok, that is? I'll also address the formatting errors (you can ignore v2 - it just contained a bug fix but without the coming changes). Thanks! --------------oOmosafgS3D5pfSYJYxWY2A9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit 
This will definitely need some tests writing for it.  It might be
possible to just add some additional cases to gdb.python/py-events.exp
to cover this new functionality.
I'll get to that. I'll probably add a completely new test, because I find the Tcl test suites more or less unintelligible, so altering them becomes almost unreasonably difficult to modify and still be sure that the test still tests what it was meant to. If that's ok, that is?

I'll also address the formatting errors (you can ignore v2 - it just contained a bug fix but without the coming changes).

Thanks!

--------------oOmosafgS3D5pfSYJYxWY2A9--