From: Pedro Alves <palves@redhat.com>
To: Paul Koning <paulkoning@comcast.net>, John Baldwin <jhb@FreeBSD.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb] fix unsigned overflow in charset.c
Date: Wed, 17 Oct 2018 21:51:00 -0000 [thread overview]
Message-ID: <0addc221-09f0-36e0-9bf4-370472a23a53@redhat.com> (raw)
In-Reply-To: <15814BE7-1C4F-4067-99A5-A004D094FB96@comcast.net>
On 10/17/2018 07:47 PM, Paul Koning wrote:
>
>
>> On Oct 17, 2018, at 2:38 PM, John Baldwin <jhb@FreeBSD.org> wrote:
>>
>>> ...
>>> From an aesthetic perspective, "ssize_t" seems better, as the "obvious
>>> signed version of size_t". From a pedantic perspective, ptrdiff_t
>>> sounds better.
>>
>> Ok, I think ssize_t is probably fine, so I Think Paul's original patch is
>> ok?
>>
>> --
>> John Baldwin
>
> Please let me know; I can commit that patch if it is approved. Or commit with changes if that's desired.
Patch is OK as is. Please push.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-10-17 21:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 17:19 Paul Koning
2018-10-09 17:31 ` Pedro Alves
2018-10-09 17:40 ` Paul Koning
2018-10-09 17:57 ` John Baldwin
2018-10-09 18:10 ` Paul Koning
2018-10-09 19:58 ` John Baldwin
2018-10-10 8:51 ` Pedro Alves
2018-10-11 20:16 ` John Baldwin
2018-10-16 15:58 ` Pedro Alves
2018-10-17 18:38 ` John Baldwin
2018-10-17 18:47 ` Paul Koning
2018-10-17 21:51 ` Pedro Alves [this message]
2018-10-17 23:28 ` Paul Koning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0addc221-09f0-36e0-9bf4-370472a23a53@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
--cc=paulkoning@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox