Re: [PATCH 36/40] Add comprehensive C++ operator linespec/location/completion tests

Keith Seitz
2017-08-09T17:59:14Z

On 06/02/2017 05:22 AM, Pedro Alves wrote:
>
> Grows the gdb.linespec/ tests like this:
>
> -# of expected passes 4458
> +# of expected passes 8817

Again, this is awesome.

Just one little nit.

> diff --git a/gdb/testsuite/gdb.linespec/cpls-ops.cc b/gdb/testsuite/gdb.linespec/cpls-ops.cc
> new file mode 100644
> index 0000000..c1156f1
> --- /dev/null
> +++ b/gdb/testsuite/gdb.linespec/cpls-ops.cc
> @@ -0,0 +1,253 @@
[snip]
> +
> +test_op_conversion::operator const volatile test_op_conversion_res **() const volatile

line length == 86

> +{
> + return NULL;
> +}
> +
[snip]

Otherwise, LGTM.

Keith