Re: [PATCH 08/40] completion_list_add_name wrapper functions

Yao Qi
2017-06-27T12:56:26Z

Pedro Alves <palves@redhat.com> writes:

> I've had to adjust these macros numerous times while working on this
> series, adding/removing parameters while experimenting with designs.
> At some point, I got fed up with fighting the preprocessor, and
> decided to make them proper functions.
>
> gdb/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * symtab.c (COMPLETION_LIST_ADD_SYMBOL)
> (MCOMPLETION_LIST_ADD_SYMBOL): Delete macros, replace with ...
> (completion_list_add_symbol, completion_list_add_msymbol):
> ... these new functions.
> (add_symtab_completions)
> (default_make_symbol_completion_list_break_on_1): Adjust.

It is obvious. Patch is good to me.

--
Yao (齐尧)