Re: [PATCH 30/40] Use search_domain::FUNCTIONS_DOMAIN when setting breakpoints

Keith Seitz
2017-08-08T21:07:31Z

On 06/02/2017 05:22 AM, Pedro Alves wrote:

> however, we're currently passing down search_domain::ALL_DOMAIN when
> we know we're looking for functions, for no good reason. This patch
> fixes that.

I have a similar patch on the compile branch.

> gdb/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * linespec.c (iterate_over_all_matching_symtabs): Add
> search_domain parameter. Pass it down to expand_symtabs_matching.
> (decode_objc): Request FUNCTIONS_DOMAIN symbols only.
> (lookup_prefix_sym): Adjust by passing ALL_DOMAIN as
> search_domain.
> (add_all_symbol_names_from_pspace): Add search_domain parameter.
> Pass it down.
> (find_method, find_function_symbols): Request FUNCTIONS_DOMAIN
> symbols.
> (add_matching_symbols_to_info): Add search_domain parameter. Pass
> it down.

LGTM

Keith