From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85009 invoked by alias); 16 Jun 2017 16:12:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84990 invoked by uid 89); 16 Jun 2017 16:12:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy= X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Jun 2017 16:12:18 +0000 Received: from John-Baldwins-MacBook-Pro-2.local (d-24-245-127-120.cpe.metrocast.net [24.245.127.120]) by mail.baldwin.cx (Postfix) with ESMTPSA id 7B00C10AB01; Fri, 16 Jun 2017 12:12:21 -0400 (EDT) Subject: Re: [PATCH 0/5] Remove a few hurdles of compiling with clang To: Pedro Alves , Eli Zaretskii , Simon Marchi References: <1497124689-11842-1-git-send-email-simon.marchi@ericsson.com> <83tw3n5jyk.fsf@gnu.org> <86tw3labb0.fsf@gmail.com> <83a85d5l4n.fsf@gnu.org> <93eb64489ac9d53665a144ddf5a966d5@polymtl.ca> <83wp8h40lo.fsf@gnu.org> <8660g0dzau.fsf@gmail.com> <83k24g3qcx.fsf@gnu.org> <83a85b4rrs.fsf@gnu.org> <5c75dd67a82d99cfe0befdfe777abcc9@polymtl.ca> <831sqn4801.fsf@gnu.org> <940cfa4e-b3cb-f15d-93cd-62bd839ab4f0@redhat.com> Cc: qiyaoltc@gmail.com, gdb-patches@sourceware.org From: John Baldwin Message-ID: <0a85851c-fd2d-8eab-264a-814930154966@FreeBSD.org> Date: Fri, 16 Jun 2017 16:12:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <940cfa4e-b3cb-f15d-93cd-62bd839ab4f0@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00462.txt.bz2 On 6/14/17 6:45 AM, Pedro Alves wrote: > Or better even, just don't skip two registers at a time? > The code is manually printing two columns on each iteration. > How about the patchlet below instead? I'd call it a clean up on > its own right. I prefer this fix and agree. Other places that try to print registers in columns (mips-tdep.c) iterate one register at a time and make the newline conditional, so this pattern is consistent with that. -- John Baldwin