From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4FtyC5kj3GPiXCgAWB0awg (envelope-from ) for ; Thu, 02 Feb 2023 15:56:57 -0500 Received: by simark.ca (Postfix, from userid 112) id 2CA391E128; Thu, 2 Feb 2023 15:56:57 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=HfYiLmwW; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DCD641E110 for ; Thu, 2 Feb 2023 15:56:56 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0E8EA3858407 for ; Thu, 2 Feb 2023 20:56:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0E8EA3858407 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675371416; bh=ea2Dbb6wAAtbO2Df5fZBdHmWAFaAeB+kcMnZ+vtzH7c=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=HfYiLmwWYcg0LJtIipePt/4qEi91H1hzG5eQWZWGkTxZHF9TItgcfZIfd0gYhlJbr gmbrSFzxXKGrS/WYbDw1y8Sx7jMRO0+Gj84zId9nxNSW6EmKmmCrC37QL53ESKormt AR4Fnvy1rrIAMdFZ3JU23QnubdlG7XNiF/NDLfRg= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 214DF3858C52 for ; Thu, 2 Feb 2023 20:56:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 214DF3858C52 Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 592C91E110; Thu, 2 Feb 2023 15:56:36 -0500 (EST) Message-ID: <0a699595-7fbf-827e-9658-63a27def846d@simark.ca> Date: Thu, 2 Feb 2023 15:56:35 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 5/8] gdbserver: Transmit target description ID in thread list and stop reply Content-Language: en-US To: Thiago Jung Bauermann Cc: Andrew Burgess , Thiago Jung Bauermann via Gdb-patches , Simon Marchi References: <20230130044518.3322695-1-thiago.bauermann@linaro.org> <20230130044518.3322695-6-thiago.bauermann@linaro.org> <87lelhtwqv.fsf@redhat.com> <87mt5vajoz.fsf@linaro.org> In-Reply-To: <87mt5vajoz.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > I agree it makes more sense to use hex everywhere. > > In the case of XML attribute fields, enforcing hex would mean adding a > base parameter to xml_parse_unsigned_integer (which currently accepts > decimal, octal and hex). I'll do that. > > In the case of the core field, to avoid breaking existing stubs it's > probably better to document that it can accept any of the three bases. The "core" field is parsed using gdb_xml_parse_attr_ulongest, which uses strtoulst with a base of 0. So I suppose that an hex value with the 0x prefix would work. So bases other than 10 can work, but they need to have the appropriate prefix. Simon