From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2036 invoked by alias); 27 Sep 2017 11:32:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2025 invoked by uid 89); 27 Sep 2017 11:32:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1300, life X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Sep 2017 11:32:22 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6B6D56146A; Wed, 27 Sep 2017 11:32:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6B6D56146A Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id A7F497C120; Wed, 27 Sep 2017 11:32:20 +0000 (UTC) Subject: Re: [RFA] Add support for __VA_OPT__ To: Tom Tromey References: <20170918024223.5607-1-tom@tromey.com> <31c997d6-8866-2080-5fd2-ebed0871c98f@redhat.com> <874lrwsonf.fsf@tromey.com> <63ab0211-8160-7ef2-5c9d-cfe5e85f9258@redhat.com> <87fubei0a4.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <0a673716-9823-1dcd-24e1-7b57dd21bc4d@redhat.com> Date: Wed, 27 Sep 2017 11:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87fubei0a4.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00823.txt.bz2 On 09/23/2017 04:03 AM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > >>> But I wonder if gdb should just error() on the invalid ones. >>> My first thought was no, why make life harder -- but at the same time, >>> the invalid cases really aren't that useful either. > > Pedro> Yeah, error might be better - e.g., for someone trying > Pedro> to write a "macro define" interactively (without > Pedro> going via the compiler first), and puzzling about why it > Pedro> doesn't exactly work [due to some typo]. But we can > Pedro> decide to do that incrementally. Fine with me to push > Pedro> as is if you'd like. > > I've switched it; and good thing, too, because this caught a bug in the > previous patch that could cause an infinite loop. > Nice. Patch looks good. Please push. > + /* Whether the loop should keep going. */ > + bool keep_going = true; 'keep_going' doesn't appear used after the loop. Could it be declared in the for's init statement ? for (bool keep_going = true; keep_going; ... > + > + for (; > + keep_going; > + get_next_token_for_substitution (&replacement_list, > + &tok, > + &original_rl_start, > + &lookahead, > + &lookahead_rl_start, > + &lookahead_valid, > + &keep_going)) > { Thanks, Pedro Alves