From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4G3SOVEXHWK2VQAAWB0awg (envelope-from ) for ; Mon, 28 Feb 2022 13:41:21 -0500 Received: by simark.ca (Postfix, from userid 112) id EA4DB1F3C8; Mon, 28 Feb 2022 13:41:21 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 73A0E1EDF0 for ; Mon, 28 Feb 2022 13:41:21 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 13A473858C60 for ; Mon, 28 Feb 2022 18:41:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 13A473858C60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1646073681; bh=TY2EKr9wyX7S8bcUhu3aCAF1y7c/lC9fm+yYTZakqCY=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=HTMcdCt8G3Oj8/TB35u6ZW67rwjwLAIX5GZYkCqCSjG8W5NFR3yWt2weC0q/G6EJz g288LUks2UWca5il+o5iUIXO3nGXhxU5kQmj/va5GA7KqUr+0uIDPo19ndT54ZGwhm dFDvlzaZHWnQfkUeP2UP/Uk2LF62s2pdITJyvNww= Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) by sourceware.org (Postfix) with ESMTPS id 56DCB3858C83 for ; Mon, 28 Feb 2022 18:40:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 56DCB3858C83 Received: by mail-qv1-xf2f.google.com with SMTP id c14so9221624qvk.10 for ; Mon, 28 Feb 2022 10:40:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TY2EKr9wyX7S8bcUhu3aCAF1y7c/lC9fm+yYTZakqCY=; b=2TmtYp7piOZ2j/eKyARjs4DUjXGGIbFgPopbWFlW9rv52ItF9Wnx/zrNp7TfB2gdX3 WEpir3NPgtwrgaaVXCDI5Gd+wBytbADyDOKbpI1qKHBVlQ+gjf1YewUR4qIsRkyD2x1p jQxOLFPJwtvym6ZYuKCvffTiCLkWgu0AiKB6hYoaGOps6Ek/lQl0NEEg8DMp+07BBxKC +FrX4Jzfds2Sh1ve/aj5aekDyvLVw69pUKEnvZZbNVUHII8KRt0VO9ZDOZQs0tOrvKmj 9sNs2LUD0NzI9nXc6+kaqkT9WaATcKdArNcptQB8xxATvFnijsOSSmf84A9J+ogzpgko 6D2w== X-Gm-Message-State: AOAM530oW94PV4XDBfZLTg9T8jbVQiGIbkW4/Y5nTFLir3gHzGvS5BQS 9wvLC0l7m5l90QdrRRndtoY= X-Google-Smtp-Source: ABdhPJzYiG/PBZjPPQm1rpe1Cr3LVTM8zfOtVD9T07x9YgC2l8P/J4hfU+UXAvm8kOSGLzbopdS02A== X-Received: by 2002:ac8:534e:0:b0:2d7:fd81:7e6 with SMTP id d14-20020ac8534e000000b002d7fd8107e6mr17965651qto.382.1646073647007; Mon, 28 Feb 2022 10:40:47 -0800 (PST) Received: from [192.168.1.127] (173-246-5-136.qc.cable.ebox.net. [173.246.5.136]) by smtp.gmail.com with ESMTPSA id f1-20020a37ad01000000b0064919f4b37csm5243545qkm.75.2022.02.28.10.40.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Feb 2022 10:40:46 -0800 (PST) Subject: Re: [RFC][PATCH v3 1/1][PR gdb/24069] gdb/darwin: skip over WIFSTOPPED wait4 status To: Simon Marchi , gdb-patches@sourceware.org References: <20220216141540.96514-1-levraiphilippeblain@gmail.com> <20220224142321.585-1-levraiphilippeblain@gmail.com> <20220224142321.585-2-levraiphilippeblain@gmail.com> <50083fbd-bb00-da50-26a6-0bc5c6dcc34d@polymtl.ca> <76ee0fd0-d42f-e811-bd96-1766e2514191@polymtl.ca> Message-ID: <0a4a8f92-a9b7-090d-1dfc-82416b121e06@gmail.com> Date: Mon, 28 Feb 2022 13:40:45 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <76ee0fd0-d42f-e811-bd96-1766e2514191@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Philippe Blain via Gdb-patches Reply-To: Philippe Blain Cc: Louis-He <1726110778@qq.com>, Dominique Quatravaux , Sam Warner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Le 2022-02-28 à 13:34, Simon Marchi a écrit : > > > On 2022-02-28 12:52, Philippe Blain wrote: >> Hi Simon, >> >> Le 2022-02-24 à 10:49, Simon Marchi a écrit : >>> >>> >>> On 2022-02-24 09:23, Philippe Blain wrote: >>>> From: Dominique Quatravaux >>>>> >>>> >>>> PR gdb/24609 >>>> * gdb/darwin-nat.c (darwin_nat_target::decode_message): Also >>>> check for WIFSTOPPED upon MACH_NOTIFY_DEAD_NAME. >>> >>> Thanks, pushed. >>> >>> Simon >>> >> >> I noticed that the Bugzilla entry was not updated when you pushed >> that commit, whereas it was for the previous one [1]. I'm not sure >> of what is the automation that makes this work... >> >> I thought it was because my changelog entry mistakenly used 24609 instead >> of 24069, but that was the case also for v2 1/2, so I guess that's not >> the cause... > > Patch #1 had a link to the correct bugzilla ticket in its commit message, > so the connection was made. > > Patch #2 didn't have any mention of the bugzilla ticket, so there was > no connection. > > The correct thing to do nowadays, according to our standard procedures, > would have been to use the: > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=24069 > > trailer. But I often forget about it. > > Simon Noted. I just checked the ContributionChecklist page and see you've updated it, thanks :) Philippe. [1] https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_formatted_commit_messages