Re: [PATCH] gdb/testsuite/gdb.rocm: Fix incorrect use of continue N in multi-inferior-gpu.exp

Simon Marchi
2023-10-17T14:26:09Z

On 10/17/23 07:16, Lancelot Six wrote:
> The gdb.rocm/multi-inferior-gpu.exp testcase uses a "continue $thread"
> command, but this is incorrect. If "continue" is given an argument, it
> sets the ignore count of the breakpoint the thread stopped at.
>
> For this testcase it does not really matter since the breakpoint is not
> meant to be hit anymore, so whatever the ignore count is won't influence
> the outcome of the test. It is worth fixing nevertheless.
>
> While at changing it, switch to using "continue&" to consume the GDB
> prompt right away. This makes the following pattern matching more
> reliable.

I don't understand the "more reliable" part, can you explain?

Simon