From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42325 invoked by alias); 30 Jan 2018 12:16:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41360 invoked by uid 89); 30 Jan 2018 12:16:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=UD:dtd, DOCTYPE, !DOCTYPE, SYSTEM X-HELO: EUR03-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr50044.outbound.protection.outlook.com (HELO EUR03-VE1-obe.outbound.protection.outlook.com) (40.107.5.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Jan 2018 12:16:42 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0643.eurprd08.prod.outlook.com (10.163.188.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Tue, 30 Jan 2018 12:16:38 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::c95:81b8:c681:ae2]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::c95:81b8:c681:ae2%17]) with mapi id 15.20.0444.016; Tue, 30 Jan 2018 12:16:38 +0000 From: Alan Hayward To: Pedro Alves CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH v2 0/8] Remove XML files from gdbserver Date: Tue, 30 Jan 2018 12:16:00 -0000 Message-ID: <0F59B133-5B59-4FA1-AB7A-7347AC35843D@arm.com> References: <7C97CC6A-92CB-4702-820D-206022F07102@arm.com> In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0643;7:HOdHFs0q/LqZrQkodou2gf22V5ZAybYlJ+kZ0vY7mD3rHiAVFfEztiDIL0QIRRKA5SScPiZF8tRo/JmoPlCd0hnl2rTW/NTjQ9cW/t4q1bY/FKgaqx2vHXOTmkRh0ERxMdcn0jOh/XmuKP0Fp5TKuLnNGmKcim8m045jnenHj3Y1u1HNDaDtBh0AFleDzUvELgTUNCA2AwMPTIND56lB3tFvkEtXMgSPlqiIT6Oosbla2zvOo5fH8VVIs+JJIyzu x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 95879b2b-2421-4b44-1816-08d567db5050 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020);SRVR:AM3PR08MB0643; x-ms-traffictypediagnostic: AM3PR08MB0643: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(158342451672863); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231101)(944501161)(93006095)(93001095)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011);SRVR:AM3PR08MB0643;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0643; x-forefront-prvs: 0568F32D91 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(376002)(39860400002)(346002)(366004)(39380400002)(189003)(199004)(51914003)(8936002)(72206003)(5660300001)(66066001)(4326008)(26005)(3280700002)(2906002)(76176011)(6436002)(3660700001)(2900100001)(99286004)(53936002)(36756003)(106356001)(33656002)(68736007)(478600001)(3846002)(6506007)(54906003)(6246003)(14454004)(5250100002)(316002)(6512007)(81166006)(81156014)(7736002)(25786009)(305945005)(97736004)(82746002)(8676002)(53546011)(83716003)(102836004)(6116002)(229853002)(186003)(2950100002)(6916009)(6486002)(86362001)(105586002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0643;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: tUjBLTzq0pXbaFH1pd9hctJhSxVnFKHVZswcWddMPd+Jjlsl50RBnWFxYBq0L59zIcFvtoDhZm8lVelkJvp76w== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95879b2b-2421-4b44-1816-08d567db5050 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2018 12:16:38.4624 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0643 X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00626.txt.bz2 DQoNCj4gT24gMjkgSmFuIDIwMTgsIGF0IDE4OjE4LCBQZWRybyBBbHZlcyA8 cGFsdmVzQHJlZGhhdC5jb20+IHdyb3RlOg0KPiANCj4gT24gMDEvMjQvMjAx OCAwOToyNiBBTSwgQWxhbiBIYXl3YXJkIHdyb3RlOg0KPj4gSW4gZXhpc2l0 aW5nIGNvZGUsIGdkYnNlcnZlciB1c2VzIEMgY29kZSBhdXRvIGdlbmVyYXRl ZCBmcm9tIHhtbCBmaWxlcyB0bw0KPj4gY3JlYXRlIHRhcmdldCBkZXNjcmlw dGlvbnMuIFdoZW4gc2VuZGluZyBhbiB4bWwgZGVzY3JpcHRpb24gdG8gR0RC LCBpdA0KPj4gY3JlYXRlcyBhbiB4bWwgY29udGFpbmluZyBqdXN0IHRoZSBu YW1lIG9mIHRoZSBvcmlnaW5hbCB4bWwgZmlsZS4NCj4+IFVwb24gcmVjZWlw dCwgR0RCIHJlYWRzIGFuZCBwYXJzZXMgYSBsb2NhbCBjb3B5IG9mIHhtbCBm aWxlLg0KPiANCj4gSHVoPyAgV2hhdCBkbyB5b3UgbWVhbiByZWFkcyBhbmQg cGFyc2VzIGEgX2xvY2FsIGNvcHlfPw0KPiBUaGF0J3MgZmFsc2UgQUZBSUNT Lg0KPiANCj4gR0RCIGZldGNoZXMgbmFtZWQgZmlsZSBmcm9tIHRoZSBzZXJ2 ZXIsIG5vdCBmcm9tIHRoZSBsb2NhbCBmaWxlc3lzdGVtLg0KPiBFLmcuLCBv biB4ODYtNjQ6DQo+IA0KPiBTZW5kaW5nIHBhY2tldDogJHFYZmVyOmZlYXR1 cmVzOnJlYWQ6dGFyZ2V0LnhtbDowLGZmZiM3ZC4uLlBhY2tldCByZWNlaXZl ZDogbDw/eG1sIHZlcnNpb249IjEuMCI/PjwhRE9DVFlQRSB0YXJnZXQgU1lT VEVNICJnZGItdGFyZ2V0LmR0ZCI+PHRhcmdldD48YXJjaGl0ZWN0dXJlPmkz ODY6eDg2LTY0PC9hcmNoaXRlY3R1cmU+PG9zYWJpPkdOVS9MaW51eDwvb3Nh Ymk+PHhpOmluY2x1ZGUgaHJlZj0iNjRiaXQtY29yZS54bWwiLz48eGk6aW5j bHVkZSBocmVmPSI2NGJpdC1zc2UueG1sIi8+PHhpOmluY2x1ZGUgaHJlZj0i NjRiaXQtbGludXgueG1sIi8+PHhpOmluY2x1ZGUgaHJlZj0iNjRiaXQtc2Vn bWVudHMueG1sIi8+PHhpOmluY2x1ZGUgaHJlZj0iNjRiaXQtYXZ4LnhtbCIv PjwvdGFyZ2V0Pg0KPiBTZW5kaW5nIHBhY2tldDogJHFYZmVyOmZlYXR1cmVz OnJlYWQ6NjRiaXQtY29yZS54bWw6MCxmZmYjNzUuLi5QYWNrZXQgcmVjZWl2 ZWQ6IGw8P3htbCB2ZXJzaW9uPSIxLjAiPz5cbjwhLS0gQ29weXJpZ2h0IChD KSAyMDEwLTIwMTggRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuXG5c biAgICAgQ29weWluZyBhbmQgZGlzdHJpYnV0aW9uIG9mIHRoaXMgZmlsZSwg d2l0aCBvciB3aXRob3V0IG1vZGlmaWNhdGlvbixcbiAgICAgYXJlIHBlcm1p dHRlZCBpbiBhbnkgbWVkaXVtIHdpdGhvdXQgcm95YWx0eSBwcm92aWRlZCB0 aGUgY29weXJpZ2h0XG4gICAgIG5vdGljZSBhbmQgdGhpcyBub3RpY2UgYXJl IHByZXNlcnZlZC4gIC0tPlxuXG48IURPQ1RZUEUgZmVhdHVyZSBTWVNURU0g ImdkYi10YXJnZXQuZHRkIj5cbjxmZWF0dXJlIG5hbWU9Im9yZy5nbnUuZ2Ri LmkzODYuY29yZSI+XG4gIDxmbGFncyBpZD0iaTM4Nl9lZmxhZ3MiIHNpemU9 IjQiPlxuICAgIDxmaWVsZCBuYW1lPSJDRiIgc3RhcnQ9IjAiIGVuZD0iMCIv PlxuICAgIDxmaWVsZCBuYW1lPSIiIHN0YXJ0PSIxIiBlbmQ9IjEiLz5cbiAg ICA8ZmllbGQgbmFtZT0iUEYiIHN0YXJ0PSIyIiBlbmQ9WzEyIGJ5dGVzIG9t aXR0ZWRdDQoNClllcywgSSBtaXN1bmRlcnN0b29kIHdoYXQgd2FzIGhhcHBl bmluZyBoZXJlLg0KKFRoZSByZXZpZXcgb2YgdGhlIGZpbmFsIHBhdGNoIG9m IHYxIGNsZWFyZWQgdGhpcyB1cCBmb3IgbWUsIGJ1dCBJIG5ldmVyIHVwZGF0 ZWQNCiB0aGlzIHBhcnQgb2YgdGhlIGFic3RyYWN0IGZvciB2MikuDQoNCklu c3RlYWQgSSBzaG91bGQgaGF2ZSBzYWlkIHNvbWV0aGluZyBsaWtlOg0KDQpJ biBleGlzaXRpbmcgY29kZSwgZ2Ric2VydmVyIHVzZXMgQyBjb2RlIGF1dG8g Z2VuZXJhdGVkIGZyb20geG1sIGZpbGVzIHRvDQpjcmVhdGUgdGFyZ2V0IGRl c2NyaXB0aW9ucy4gV2hlbiBzZW5kaW5nIGFuIHhtbCBkZXNjcmlwdGlvbiB0 byBHREIsIGl0DQpjcmVhdGVzIGFuIHhtbCBjb250YWluaW5nIHRoZSBuYW1l IG9mIHRoZSBvcmlnaW5hbCB4bWwgZmlsZShzKS4NCkdEQiBwYXJzZXMgdGhl IHhtbCBhbmQgdGhlbiByZXF1ZXN0cyBmcm9tIGdkYnNlcnZlciBhIGNvcHkg b2YgZWFjaCBvZg0KdGhlIGluY2x1ZGVkIGZpbGVzLg0KV2l0aCB0aGlzIG5l dyBwYXRjaCwgd2UgYWRkIGNvbW1vbiBjb2RlIHRoYXQgYWxsb3dzIGdkYnNl cnZlciAoYW5kIGdkYikNCnRvIHR1cm4gYSBDIHRhcmdldCBkZXNjcmlwdGlv biBzdHJ1Y3R1cmUgaW50byB4bWwuIE5vdyB3aGVuIHNlbmRpbmcgYW4geG1s DQpkZXNjcmlwdGlvbiB0byBnZGIsIGdkYnNlcnZlciBjcmVhdGVzIGEgc2lu Z2xlIHhtbCBzdHJ1Y3R1cmUgY29udGFpbmluZyB0aGUNCmVudGlyZSB0YXJn ZXQgZGVzY3JpcHRpb24sIHdpdGhvdXQgYW55IGluY2x1ZGVzLiBHREIgbm8g bG9uZ2VyIG5lZWRzIHRvIGFzaw0KZm9yIGFkZGl0aW9uYWwgeG1sIHBhY2tl dHMgZnJvbSBnZGJzZXJ2ZXIuDQoNCj4gDQo+IEFib3ZlIHdlIHNlZSBHREIg cHJvY2Vzc2luZyB0aGUgeGk6aW5jbHVkZXMgYnkgc3Vic2VxdWVudGx5IGZl dGNoaW5nIHRoZQ0KPiB4aTppbmNsdWRlZCBmaWxlcyBmcm9tIHRoZSBzZXJ2 ZXIuDQo+IA0KPiBUaGVyZSBpcyBhbHJlYWR5IHNvbWUgc3VwcG9ydCBpbiBn ZGJzZXJ2ZXIgZm9yIGJha2luZyBpbiB0aGUgWE1MDQo+IGNvZGUgZGlyZWN0 bHkgaW4gZ2Ric2VydmVyIGluc3RlYWQgb2YgcmVhZGluZyBpdCBmcm9tIChn ZGJzZXJ2ZXIncykNCj4gZmlsZXN5c3RlbToNCj4gDQo+ICAvKiBgZGVzYy0+ eG1sdGFyZ2V0JyBkZWZpbmVzIHdoYXQgdG8gcmV0dXJuIHdoZW4gbG9va2lu ZyBmb3IgdGhlDQo+ICAgICAidGFyZ2V0LnhtbCIgZmlsZS4gIEl0cyBjb250 ZW50cyBjYW4gZWl0aGVyIGJlIHZlcmJhdGltIFhNTCBjb2RlDQo+ICAgICAo cHJlZml4ZWQgd2l0aCBhICdAJykgb3IgZWxzZSB0aGUgbmFtZSBvZiB0aGUg YWN0dWFsIFhNTCBmaWxlIHRvDQo+ICAgICBiZSB1c2VkIGluIHBsYWNlIG9m ICJ0YXJnZXQueG1sIi4NCj4gDQo+ICAgICBUaGlzIHZhcmlhYmxlIGlzIHNl dCB1cCBmcm9tIHRoZSBhdXRvLWdlbmVyYXRlZA0KPiAgICAgaW5pdF9yZWdp c3RlcnNfLi4uIHJvdXRpbmUgZm9yIHRoZSBjdXJyZW50IHRhcmdldC4gICov DQo+IA0KPiAgaWYgKHN0cmNtcCAoYW5uZXgsICJ0YXJnZXQueG1sIikgPT0g MCkNCj4gICAgew0KPiAgICAgIGNvbnN0IGNoYXIgKnJldCA9IHRkZXNjX2dl dF9mZWF0dXJlc194bWwgKCh0YXJnZXRfZGVzYyopIGRlc2MpOw0KPiANCj4g ICAgICBpZiAoKnJldCA9PSAnQCcpDQo+IAlyZXR1cm4gcmV0ICsgMTsNCj4g ICAgICBlbHNlDQo+IAlhbm5leCA9IHJldDsNCj4gICAgfQ0KDQpFc3NlbnRp YWxseSwgdGRlc2NfZ2V0X2ZlYXR1cmVzX3htbCgpIGlzIHRoZSBmdW5jdGlv biBJIGFtIHJld3JpdGluZyB3aXRoIHRoaXMgc2VyaWVzLg0KDQpJbiB0aGUg ZXhpc3RpbmcgY29kZSBpdCB3aWxsIHByb2R1Y2Ugc29tZXRoaW5nIGxpa2U6 DQoNCjwhRE9DVFlQRSB0YXJnZXQgU1lTVEVNICJnZGItdGFyZ2V0LmR0ZCI+ DQo8dGFyZ2V0Pg0KICA8YXJjaGl0ZWN0dXJlPmkzODY8L2FyY2hpdGVjdHVy ZT4NCiAgPG9zYWJpPkdOVS9MaW51eDwvb3NhYmk+DQogIDx4aTppbmNsdWRl IGhyZWY9IjMyYml0LWNvcmUueG1sIi8+DQogIDx4aTppbmNsdWRlIGhyZWY9 IjMyYml0LXNzZS54bWwiLz4NCiAgPHhpOmluY2x1ZGUgaHJlZj0iMzJiaXQt bGludXgueG1sIi8+DQogIDx4aTppbmNsdWRlIGhyZWY9IjMyYml0LWF2eC54 bWwiLz4NCjwvdGFyZ2V0Pg0KDQpNeSBwYXRjaCByZW1vdmVzIHRoZSBpbmNs dWRlIHNlY3Rpb25zIGFuZCBpbnN0ZWFkIGR1bXBzIHRoZSBlbnRpcmUgeG1s Og0KDQo8IURPQ1RZUEUgdGFyZ2V0IFNZU1RFTSAiZ2RiLXRhcmdldC5kdGQi Pg0KPHRhcmdldD4NCiAgPGFyY2hpdGVjdHVyZT5pMzg2PC9hcmNoaXRlY3R1 cmU+DQogIDxvc2FiaT5HTlUvTGludXg8L29zYWJpPg0KICA8ZmVhdHVyZSBu YW1lPSJvcmcuZ251LmdkYi5pMzg2LmNvcmUiPg0KICAgIDxmbGFncyBpZD0i aTM4Nl9lZmxhZ3MiIHNpemU9IjQiPg0KICAgICAgPGZpZWxkIG5hbWU9IkNG IiBzdGFydD0iMCIgZW5kPSIwIi8+DQogICAgICA8ZmllbGQgbmFtZT0iIiBz dGFydD0iMSIgZW5kPSIxIi8+DQogICAgICA8ZmllbGQgbmFtZT0iUEYiIHN0 YXJ0PSIyIiBlbmQ9IjIiLz4NCiAgICAgIDxmaWVsZCBuYW1lPSJBRiIgc3Rh cnQ9IjQiIGVuZD0iNCIvPg0KLi4uZXRjIA0KDQo+IA0KPiBDYW4geW91IHBs ZWFzZSBjbGFyaWZ5IHRoZSByYXRpb25hbGUgZm9yIHRoZSBzZXJpZXM/DQo+ IA0KPiBUaGUgY3VycmVudCBqdXN0aWZpY2F0aW9uIGRvZXNuJ3QgbG9vayB2 ZXJ5IGNvbnZpbmNpbmcgdG8gbWUuICBUaGlzDQo+IGlzIGdvaW5nIHRvIGJl IHByb2JhYmx5IHNvbWV0aGluZyBhcm91bmQgZHluYW1pYyBnZW5lcmF0aW9u IG9mIFhNTA0KPiBkZXNjcmlwdGlvbnMgYmFzZWQgb24gQ1BVIG9wdGlvbmFs IGZlYXR1cmVzLCBpbnN0ZWFkIG9mIGhhdmluZw0KPiB0byBoYXZlIGdkYnNl cnZlciBjYXJyeSBhIGJ1bmNoIG9mIGRpZmZlcmVudCBYTUwgZmlsZXMgZm9y IGVhY2ggcG9zc2libGUNCj4gY29tYmluYXRpb24gb2Ygb3B0aW9uYWwgZmVh dHVyZXMuICAoSS5lLiwgYSBjb250aW51YXRpb24gb2YgWWFvJ3MNCj4gZWFy bGllciB3b3JrKS4NCg0KVGhlIHJlYXNvbiBmb3IgbWUgd3JpdGluZyB0aGUg cGF0Y2ggc2VyaWVzIGlzIGV2ZW50dWFsbHkgdG8gc3VwcG9ydCBhYXJjaDY0 IHN2ZS4NCldpdGggc3ZlIEkgd2FudCB0byBhdm9pZCBjcmVhdGluZyBhbiB4 bWwgZmlsZSBmb3IgZXZlcnkgc3ZlIHNpemUgcG9zc2liaWxpdHkuDQpXaXRo IHRoaXMgcGF0Y2ggaW4gcGxhY2UsIEkgY2FuIGF2b2lkIGNyZWF0aW5nIHht bCBmaWxlcyBmb3Igc3ZlIGFuZCBpbnN0ZWFkIHdyaXRlDQp0aGUgLmMgY29k ZSAodGhhdCB3b3VsZCBub3JtYWxseSBiZSBnZW5lcmF0ZWQgZnJvbSB0aGUg eG1sKQ0KTWF5YmUgSSBzaG91bGQgaGF2ZSBtZW50aW9uZWQgdGhhdCBpbiB0 aGUgYWJzdHJhY3QsIGJ1dCBJIHdhbnRlZCB0byBhdm9pZCBiaW5kaW5nDQp0 aGlzIHBhdGNoIHRvIGZ1dHVyZSB3b3JrLg0KDQpUaGUgcmF0aW9uYWwgZm9y IHRoaXMgcGF0Y2ggdGhlbiBpcyB0aGF0IGlzIHJlbW92ZXMgdGhlIG5lZWQg Zm9yIGdkYnNlcnZlciB0byBpbmNsdWRlDQp4bWwgZmlsZXMgYW5kIGl0IG1l YW5zIGEgZ2l2ZW4gdGFyZ2V0IGNhbiBoYXZlIGp1c3QgYSAuYyBmaWxlIGlu IGZlYXR1cmVzLyBpbnN0ZWFkIG9mDQphbiB4bWwgYW5kIGdlbmVyYXRlZCAu YyBmaWxlLg0KDQo+IA0KPiBJIGhhdmVuJ3QgcmVhZCB0aGUgcGF0Y2hlcywg YnV0IGl0J3MgbGlrZWx5IHRoYXQgeW91IHNob3VsZCBuZWVkDQo+IHRvIHR3 ZWFrIHRoZSBpbmRpdmlkdWFsIHBhdGNoZXMnIHJhdGlvbmFsZXMgdG9vLg0K DQpJ4oCZbGwgbG9vayB0aHJvdWdoIHRoZW0uDQoNClRoYW5rcyBmb3IgdGhl IHJldmlldyENCg0KPiANCj4gVGhhbmtzLA0KPiBQZWRybyBBbHZlcw0KDQo= >From gdb-patches-return-145153-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Jan 30 12:39:08 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 11670 invoked by alias); 30 Jan 2018 12:39:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 11659 invoked by uid 89); 30 Jan 2018 12:39:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=won X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Jan 2018 12:39:06 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 10AC219D04E; Tue, 30 Jan 2018 12:39:05 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 25B4860BE0; Tue, 30 Jan 2018 12:39:02 +0000 (UTC) Subject: Re: [RFA/linespec] wrong line number in breakpoint location To: Joel Brobecker , Simon Marchi References: <1513565091-118926-1-git-send-email-brobecker@adacore.com> <20171219092405.n2dql5ji52qhjilj@adacore.com> <206d75d6b1f14e55b6a0dff523d8c722@polymtl.ca> <20171221113127.ijqv6dnzjfifwfnb@adacore.com> <20171221113214.hezwvaatnbd4yzfq@adacore.com> <5bc2ff63-7341-4000-8ec4-d56c87779c3d@ericsson.com> <20180129044505.mtvh2ps464imwp2t@adacore.com> <20180130040949.mbvm33n7atqvuik3@adacore.com> Cc: Simon Marchi , gdb-patches@sourceware.org, Keith Seitz , Xavier Roirand From: Pedro Alves Message-ID: Date: Tue, 30 Jan 2018 12:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180130040949.mbvm33n7atqvuik3@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-01/txt/msg00627.txt.bz2 Content-length: 2512 On 01/30/2018 04:09 AM, Joel Brobecker wrote: >> Thanks, this is fine with me. Just a really small nit, I would suggest >> initializing the line_actual variable to 0 or -1 (an invalid line number) >> prior to calling gdb_test_multiple. This way, if that test fails, >> line_actual will still be defined, and the expression that refers to it will >> generate a FAIL instead of an unreadable tcl backtrace. > > Sounds good. Just for kicks, I took at look at what it looks like > when the variable is undefined, and the error message is obvious > about why it fails. When the error is defined, however, you have > to figure out what the difference is, and track the value of that > variable down. What won me over to your suggestion is that the > error can go unnoticed if you just compare .sum files... My view is that since "using" an undefined variable results in a TCL error, that is a testsuite bug, plain and simple. A TCL error is lower level than a dejagnu FAIL, and aborts the whole testcase, while a dejagnu FAIL indicates that the testing harness is working and caught GDB behaving unexpectedly in the particular use case being tested. A FAIL can go on and run subsequent procedures/tests. In cases like this where we're extracting variables with expect_out, we often add failed-to-extract-variable handling after the gdb_test_multiple, like this: # start with "impossible" value. set whatever -1 gdb_test_multiple $test $test { -re "whatever is ($decimal)\r\n$gdb_prompt $" { set whatever $expect_out(1,string) pass $test } } if {$whatever == -1} { # bail out, no use continuing the procedure. return } So you get a FAIL in the gdb_test_multiple case, and skip running the rest of the procedure. Sometimes we call "untested" before returning. It's a bit easier to see usefulness of the pattern if the tests _are_ put in a procedure called by a main testcase driver, like: ~~~~~~~~~~~~~~~~~~~~~~~~~~~ proc_with_prefix test_whatever {} { set whatever -1 gdb_test_multiple $test $test { -re "whatever is ($decimal)\r\n$gdb_prompt $" { set whatever $expect_out(1,string) pass $test } } if {$whatever == -1} { # bail out, no use continuing the procedure. return } } proc_with_prefix test_whatever_else {} { ... } # The drive code that calls test procedures. test_whatever test_whatever_else ~~~~~~~~~~~~~~~~~~~~~~~~~~~ And now test_whatever_else runs even if test_whatever bails out. Thanks, Pedro Alves