From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34630 invoked by alias); 25 Sep 2015 12:06:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34608 invoked by uid 89); 25 Sep 2015 12:06:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Sep 2015 12:06:39 +0000 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id BF8207C78E73; Fri, 25 Sep 2015 13:06:30 +0100 (IST) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 25 Sep 2015 13:06:32 +0100 Received: from LEMAIL01.le.imgtec.org ([fe80::5ae:ee16:f4b9:cda9]) by LEMAIL01.le.imgtec.org ([fe80::5ae:ee16:f4b9:cda9%17]) with mapi id 14.03.0210.002; Fri, 25 Sep 2015 13:06:32 +0100 From: Andrew Bennett To: Mike Frysinger CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH] Add micromips support to the MIPS simulator Date: Fri, 25 Sep 2015 12:06:00 -0000 Message-ID: <0DA23CC379F5F945ACB41CF394B9827721126A60@LEMAIL01.le.imgtec.org> References: <0DA23CC379F5F945ACB41CF394B9827720F51185@LEMAIL01.le.imgtec.org> <20150224054441.GA6655@vapier> <0DA23CC379F5F945ACB41CF394B98277211129DE@LEMAIL01.le.imgtec.org> <20150917044236.GB6834@vapier.lan> In-Reply-To: <20150917044236.GB6834@vapier.lan> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00573.txt.bz2 PiA+IE5vLCB0aGV5IGFyZSByZXF1aXJlZCBmb3Igc29tZSBvZiB0aGUgbWFj cm9zIHVzZWQgaW4gdGhlIGZpbGUgc28gdGhleSBuZWVkDQo+IHRvDQo+ID4g c3RheSBpbi4NCj4gDQo+IHRoaXMgbmVlZHMgdG8gYmUgZG9jdW1lbnRlZCBh cyB0byB3aHkuICBvdGhlciBwb3J0cyBkb24ndCBuZWVkIHRoaXMsIGFuZA0K PiBpdCBzb3VuZHMgbGlrZSBzb21ldGhpbmcgd3Jvbmcgd2l0aCB0aGUgbWlw cyBwb3J0IHRoYXQgc2hvdWxkIGJlIGZpeGVkIGF0DQo+IHNvbWUgcG9pbnQu DQoNClRoZSBkZWZpbml0aW9ucyBjb21lIGZyb20gdGhlICpfc3VwcG9ydC5o IGZpbGVzIGdlbmVyYXRlZCBieSBpZ2VuIGFuZCBhcmUgcmVxdWlyZWQgDQpi ZWNhdXNlIHRoZXkgYXJlIHVzZWQgaW4gc29tZSBvZiB0aGUgbWFjcm9zIGlu IHRoZSBtaWNyb21pcHNydW4uYyBmaWxlLiAgDQpVbmZvcnR1bmF0ZWx5IHdl IGNhbiBub3QganVzdCBibGluZGx5IGluY2x1ZGUgdGhlICpfc3VwcG9ydC5o IGZpbGVzIHRvIGdldCB0aGVzZSANCmRlZmluaXRpb25zIGJlY2F1c2Ugc29t ZSBvZiB0aGUgZGVmaW5lcyBpbiB0aGVzZSBmaWxlcyBhcmUgc3BlY2lmaWMg Zm9yIGEgcGFydGljdWxhciANCmNvbmZpZ3VyYXRpb24gb2YgdGhlIHNpbXVs YXRvciBmb3IgZXhhbXBsZSBpbnN0cnVjdGlvbiB3b3JkIHNpemUgaXMgMTYg Yml0cyBmb3IgDQptaWNyb21pcHMxNiBhbmQgMzIgYml0cyBmb3IgbWljcm9t aXBzMzIuICBUaGlzIG1lYW5zIHdlIGNvdWxkIGJyZWFrIGZ1dHVyZSBjb2Rl IA0KY2hhbmdlcyBieSBkb2luZyB0aGlzLCBzbyBhIHNhZmVyIGFwcHJvYWNo IGlzIHRvIGp1c3QgZXh0cmFjdCB0aGUgZGVmaW5lcyB0aGF0IA0Kd2UgbmVl ZCB0byBnZXQgdGhlIGZpbGUgdG8gY29tcGlsZS4gIA0KDQpJIGhhdmUgYWRk ZWQgYSBjb21tZW50IGFib3ZlIHRoZSBkZWZpbmVzIHdoaWNoIGV4cGxhaW5z IHRoaXMuICBUaGUgZGlmZiBmcm9tIG15DQpwcmV2aW91cyBwYXRjaCBpcyBi ZWxvdy4NCg0KT2sgdG8gY29tbWl0Pw0KDQpNYW55IHRoYW5rcywNCg0KDQoN CkFuZHJldw0KDQoNCmRpZmYgLS1naXQgYS9zaW0vbWlwcy9taWNyb21pcHNy dW4uYyBiL3NpbS9taXBzL21pY3JvbWlwc3J1bi5jDQppbmRleCA3ZGQxMGQ3 Li5jMzkxMzhiIDEwMDY0NA0KLS0tIGEvc2ltL21pcHMvbWljcm9taXBzcnVu LmMNCisrKyBiL3NpbS9taXBzL21pY3JvbWlwc3J1bi5jDQpAQCAtMjYsNiAr MjYsMTQgQEANCiAjaW5jbHVkZSAiYmZkLmgiDQogI2luY2x1ZGUgInNpbS1l bmdpbmUuaCINCiANCisvKiBUaGVzZSBkZWZpbml0aW9ucyBjb21lIGZyb20g dGhlICpfc3VwcG9ydC5oIGZpbGVzIGdlbmVyYXRlZCBieSBpZ2VuIGFuZCBh cmUNCisgICByZXF1aXJlZCBiZWNhdXNlIHRoZXkgYXJlIHVzZWQgaW4gc29t ZSBvZiB0aGUgbWFjcm9zIGluIHRoZSBjb2RlIGJlbG93Lg0KKyAgIFVuZm9y dHVuYXRlbHkgd2UgY2FuIG5vdCBqdXN0IGJsaW5kbHkgaW5jbHVkZSB0aGUg Kl9zdXBwb3J0LmggZmlsZXMgdG8gZ2V0DQorICAgdGhlc2UgZGVmaW5pdGlv bnMgYmVjYXVzZSBzb21lIG9mIHRoZSBkZWZpbmVzIGluIHRoZXNlIGZpbGVz IGFyZSBzcGVjaWZpYw0KKyAgIGZvciBhIHBhcnRpY3VsYXIgY29uZmlndXJh dGlvbiBvZiB0aGUgc2ltdWxhdG9yIGZvciBleGFtcGxlIGluc3RydWN0aW9u IHdvcmQNCisgICBzaXplIGlzIDE2IGJpdHMgZm9yIG1pY3JvbWlwczE2IGFu ZCAzMiBiaXRzIGZvciBtaWNyb21pcHMzMi4gIFRoaXMgbWVhbnMgd2UNCisg ICBjb3VsZCBicmVhayBmdXR1cmUgY29kZSBjaGFuZ2VzIGJ5IGRvaW5nIHRo aXMsIHNvIGEgc2FmZXIgYXBwcm9hY2ggaXMgdG8ganVzdA0KKyAgIGV4dHJh Y3QgdGhlIGRlZmluZXMgdGhhdCB3ZSBuZWVkIHRvIGdldCB0aGlzIGZpbGUg dG8gY29tcGlsZS4gICovDQogI2RlZmluZSBTRCBzZA0KICNkZWZpbmUgQ1BV IGNwdQ0KDQo= >From gdb-patches-return-126334-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Sep 25 13:09:29 2015 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 77469 invoked by alias); 25 Sep 2015 13:09:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 77459 invoked by uid 89); 25 Sep 2015 13:09:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f44.google.com Received: from mail-pa0-f44.google.com (HELO mail-pa0-f44.google.com) (209.85.220.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 25 Sep 2015 13:09:22 +0000 Received: by pacex6 with SMTP id ex6so105777800pac.0 for ; Fri, 25 Sep 2015 06:09:21 -0700 (PDT) X-Received: by 10.68.168.97 with SMTP id zv1mr1519415pbb.86.1443186561288; Fri, 25 Sep 2015 06:09:21 -0700 (PDT) Received: from E107787-LIN (power-aix.osuosl.org. [140.211.15.154]) by smtp.gmail.com with ESMTPSA id hq8sm3987400pad.35.2015.09.25.06.09.19 (version=TLS1_2 cipher=AES128-SHA256 bits=128/128); Fri, 25 Sep 2015 06:09:20 -0700 (PDT) From: Yao Qi To: Simon Marchi Cc: Subject: Re: [PATCH 1/2] Add casts to memory allocation related calls References: <1443035686-27241-1-git-send-email-simon.marchi@ericsson.com> Date: Fri, 25 Sep 2015 13:09:00 -0000 In-Reply-To: <1443035686-27241-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Wed, 23 Sep 2015 15:14:45 -0400") Message-ID: <86k2re8x38.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00574.txt.bz2 Content-length: 639 Simon Marchi writes: Hi Simon, Thanks for doing this. Patch is OK to me. > Only files built on x86 with --enable-targets=3Dall are modified. This > means that all other -nat.c files are untouched and will have to be > dealt with later by using appropiate compilers. Or maybe we can try to > build them with a regular g++ just to know where to add casts, I don't > know. AFAIK, we had a buildbot config for this http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cxx-build-m64 Could you please cross compile GDB with cross compilers to sure -nat.c files can be covered? --=20 Yao (=E9=BD=90=E5=B0=A7)