From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27453 invoked by alias); 27 Sep 2012 14:57:13 -0000 Received: (qmail 27440 invoked by uid 22791); 27 Sep 2012 14:57:12 -0000 X-SWARE-Spam-Status: No, hits=-4.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from server-nat-6.cs.umd.edu (HELO bacon.cs.umd.edu) (128.8.127.149) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 27 Sep 2012 14:57:06 +0000 Received: from [10.109.170.227] (129-2-129-154.wireless.umd.edu [129.2.129.154]) (Authenticated sender: khooyp) by bacon.cs.umd.edu (Postfix) with ESMTPSA id C05A7B40A0C; Thu, 27 Sep 2012 10:57:01 -0400 (EDT) Subject: Re: [PATCH] Also install data-directory into the build directory as computed by relocate_gdb_directory Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Khoo Yit Phang In-Reply-To: <20120927091737.GB2980@adacore.com> Date: Thu, 27 Sep 2012 14:57:00 -0000 Cc: Khoo Yit Phang , Jan Kratochvil , GDB Patches Content-Transfer-Encoding: quoted-printable Message-Id: <0D71A524-EC00-4065-9E9E-626E87CFC75D@cs.umd.edu> References: <78B3333C-92F9-474D-8352-087C5A0F575B@cs.umd.edu> <20120924072945.GA4146@adacore.com> <20120924145910.GE4146@adacore.com> <2878953E-B698-43F3-989A-A551D96BAB62@cs.umd.edu> <20120924152641.GF4146@adacore.com> <9F52A338-A158-44DC-90C1-F46503859613@cs.umd.edu> <285502C6-1395-4049-9D55-031EDA3AD06D@cs.umd.edu> <20120924170348.GI4146@adacore.com> <20120927091737.GB2980@adacore.com> To: Joel Brobecker X-CSD-MailScanner-ID: C05A7B40A0C.A058F X-CSD-MailScanner: Found to be clean X-CSD-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-50, required 5, autolearn=not spam, ALL_TRUSTED -50.00) X-CSD-MailScanner-From: khooyp@cs.umd.edu X-CSD-MailScanner-Watermark: 1349362621.8892@0nqcoeyaUlOEF80ilCFtMw Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00633.txt.bz2 Hi, On Sep 27, 2012, at 5:17 AM, Joel Brobecker wrote: > It took me a long time to understand why you had to do things the way > you do. I would have prefered a patch that just needs to call make with > a new value for "prefix" set to "$(top_build_dir)/..", rather . But it > would not work if configured with --with-gdb-datadir. >=20 > There is an issue, I think, with your patch, unfortunately: I think > it requires GNU Make, as you are using variable substitution which > I do not think is available with all flavors of make. >=20 > There are only so many options I can see: > 1. Conditionalize this feature to having GNU Make. Not sure how to do > that, though; > 2. Compute the in-tree directory locations during the configure > step. I could rewrite it to use sed instead, which is already used in install-pyt= hon and other places. Or, we could just assume that --with-gdb-datadir or -= -bindir are not used during configuration and install with "prefix" set to = "$(top_build_dir)/..". Yit September 27, 2012