From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20901 invoked by alias); 19 Aug 2013 13:59:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20891 invoked by uid 89); 19 Aug 2013 13:59:33 -0000 X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED autolearn=ham version=3.3.2 Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 19 Aug 2013 13:59:32 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 9553B265C282; Mon, 19 Aug 2013 15:59:30 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TFvCVeKYQvtn; Mon, 19 Aug 2013 15:59:30 +0200 (CEST) Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 84A2E265B4BE; Mon, 19 Aug 2013 15:59:30 +0200 (CEST) Content-Type: text/plain; charset=iso-8859-1 Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: [RFA] Windows x64 SEH unwinder (v2) From: Tristan Gingold In-Reply-To: <51F29440.3030808@redhat.com> Date: Mon, 19 Aug 2013 13:59:00 -0000 Cc: "gdb-patches@sourceware.org ml" , Joel Brobecker Content-Transfer-Encoding: 7bit Message-Id: <0D3DA8C7-D5CE-457D-BAC2-862BBB98E486@adacore.com> References: <1357728781-15073-1-git-send-email-brobecker@adacore.com> <1357728781-15073-3-git-send-email-brobecker@adacore.com> <50ED9221.1050504@redhat.com> <9E84DF2D-7AF8-4AA1-A5DF-171EF189A6E7@adacore.com> <50EDA48E.2030406@redhat.com> <66611BA9-4536-42B2-A65C-4EA5DA219E22@adacore.com> <50EEEB3C.9050202@redhat.com> <5BE11EDB-7832-4489-8CB1-6382F5D1D34E@adacore.com> <51F29440.3030808@redhat.com> To: Pedro Alves X-SW-Source: 2013-08/txt/msg00501.txt.bz2 On Jul 26, 2013, at 5:22 PM, Pedro Alves wrote: > On 07/08/2013 11:55 AM, Tristan Gingold wrote: >> Hello, >> >> this is the second version of the patch we submitted in January. >> I have rewritten amd64_windows_frame_decode_epilogue according to the >> very serious review and comments from Pedro. > > Thanks! > > (That was here, for reference: > http://sourceware.org/ml/gdb-patches/2013-01/msg00165.html > I had to go back and read it again, I had already swapped out > all my SEH knowledge :-) ) :-) > What's the plan for debugging binaries with dwarf instead of SEH? > That'd be binaries built with gcc 4.6, IIUC. > There was the fallback idea of providing a knob to disable the > unwinder. Is that no longer necessary? Did you guys manage to > confirm what happens with those binaries? Or will we take the wait > until someone complains the missing support approach? If the latter, > than I think NEWS should mention we no longer support such binaries. > Now that I mention that, I notice the NEWS hunk is mentioned in the > ChangeLog, but it's actually missing from the patch. :-) I'd simply vote for not supporting binaries built with old versions of gcc. If a user complain, we can either add a command to disable the SEH unwinder, or (and I prefer that option) simply say: sorry, but your binary is not compliant with the x64 ABI. > Otherwise I have no further comments. It looks good to me. Ok, will commit it then (with the NEWS hunk). Tristan.