From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5870 invoked by alias); 3 Feb 2017 11:25:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5850 invoked by uid 89); 3 Feb 2017 11:25:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=extracted, Hx-languages-length:2272, H*RU:sk:EUR02-H, Hx-spam-relays-external:sk:EUR02-H X-HELO: EUR02-HE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr10089.outbound.protection.outlook.com (HELO EUR02-HE1-obe.outbound.protection.outlook.com) (40.107.1.89) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Feb 2017 11:25:46 +0000 Received: from AM5PR0801MB1809.eurprd08.prod.outlook.com (10.169.247.138) by AM5PR0801MB1810.eurprd08.prod.outlook.com (10.169.247.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.888.16; Fri, 3 Feb 2017 11:25:43 +0000 Received: from AM5PR0801MB1809.eurprd08.prod.outlook.com ([10.169.247.138]) by AM5PR0801MB1809.eurprd08.prod.outlook.com ([10.169.247.138]) with mapi id 15.01.0888.018; Fri, 3 Feb 2017 11:25:43 +0000 From: Alan Hayward To: Pedro Alves CC: Yao Qi , Joel Brobecker , "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Removal of uses of MAX_REGISTER_SIZE Date: Fri, 03 Feb 2017 11:25:00 -0000 Message-ID: <0C6A0D51-4C49-4400-8C46-E77DD512DF56@arm.com> References: <7CF07197-4FED-4970-BB4B-2FE828E29A63@arm.com> <45e3a5e1-a9aa-1bc0-5d08-526b89fc458e@redhat.com> <20170201124123.GA27498@E107787-LIN> <20170202094012.dge4r6rsl2skdrii@adacore.com> <20170203102819.GA11916@E107787-LIN> <25716edf-096e-20c5-4170-fb8ca04d897b@redhat.com> In-Reply-To: <25716edf-096e-20c5-4170-fb8ca04d897b@redhat.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-office365-filtering-correlation-id: e50204a0-c2b8-4a3b-f308-08d44c276404 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:AM5PR0801MB1810; x-microsoft-exchange-diagnostics: 1;AM5PR0801MB1810;7:KJY5HSnph5gwcq5b6zYhpgOA2PS1BmS7xQpFOkvxF6r7YHvoiTkc61NPltFCpi5v7NmQPAzvwwYnTVSKjES8j+irwUmW0Wf4Gp6NJIe04HJdHwqe/mHcDnc5Jjr+NFrSWGIWse99eI9VSLxFKRxF/0Q5EdV9JZdHw5GUTVa1Hx6413B2uHNiOLcc8NJLaKQzcCXXqQ5R2k8pw2MPs1OfNhvwB/5qfIk5wbyjPmklE/VokB/O6fDa9SdhrQRpligkni5dt/7Egl1ONr6dibJHd+Jm2w6UNwRXI3Ra5mb4SSIugKtzp/ClTHO9ou8kgYTrX3rRGtZ9CRmTl4BJ88gATFJ4PBwfj3AXiyBtqtILcdlS9+I0tSSDwC/44WRDiOtp8goaH5wle22GlA90GeDbcKNn5mnQHhT/eOq62TtjmXvgZ1u1kHvKUeYQ31NYN8uLr1LQZQhrzfbvJUiVUw+fT4bOW3m8lbmMP8DmJIR18zi6wMKlOYZBuLoOJk7DHNtXF3uM/p4Q+fMtcY+OVbfqlQ== nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(788757137089); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123558025)(20161123555025)(20161123564025)(20161123560025)(20161123562025)(6072148);SRVR:AM5PR0801MB1810;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0801MB1810; x-forefront-prvs: 02070414A1 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39840400002)(39450400003)(39860400002)(39410400002)(39850400002)(24454002)(199003)(377454003)(189002)(4326007)(105586002)(6246003)(2906002)(5660300001)(101416001)(86362001)(97736004)(68736007)(3846002)(122556002)(53546003)(106116001)(33656002)(106356001)(102836003)(6116002)(189998001)(36756003)(77096006)(38730400001)(2900100001)(6486002)(6436002)(8676002)(39060400001)(66066001)(81156014)(92566002)(8936002)(82746002)(229853002)(83716003)(93886004)(6506006)(3660700001)(54906002)(99286003)(53936002)(6512007)(25786008)(54356999)(76176999)(50986999)(305945005)(2950100002)(6916009)(3280700002)(81166006)(7736002)(110136003)(104396002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0801MB1810;H:AM5PR0801MB1809.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2017 11:25:43.1023 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1810 X-SW-Source: 2017-02/txt/msg00096.txt.bz2 DQo+IE9uIDMgRmViIDIwMTcsIGF0IDEwOjU5LCBQZWRybyBBbHZlcyA8cGFs dmVzQHJlZGhhdC5jb20+IHdyb3RlOg0KPiANCj4gT24gMDIvMDMvMjAxNyAx MDoyOCBBTSwgWWFvIFFpIHdyb3RlOg0KPiANCj4+IEkgZG9uJ3QgdGhpbmsg d2UgaGF2ZSB0byByZXBsYWNlIGFsbCBNQVhfUkVHSVNURVJfU0laRSB3aXRo IHN0ZDo6dmVjdG9yLg0KPj4gTUFYX1JFR0lTVEVSX1NJWkUgaXMgbW9zdGx5 IHVzZWQgaW4gYXJjaC1kZXBlbmRlbnQgY29kZSAoKi10ZGVwLmMNCj4+IGFu ZCAqLW5hdC5jKSwgd2hlcmUgdGhlIHJlZ2lzdGVyIHNpemUgb3IgbWF4IHJl Z2lzdGVyIHNpemUgaXMga25vd24uICBGb3INCj4+IGV4YW1wbGUsIE1BWF9S RUdJU1RFUl9TSVpFIGlzIHVzZWQgb25seSBvbmNlIGluIGFybS10ZGVwLmMs IGFuZA0KPj4gaXQgY2FuIGJlIHJlcGxhY2VkIHdpdGggRlBfUkVHSVNURVJf U0laRSwgYmVjYXVzZSAnYnVmJyBpcyB0byBnZXQgdGhlDQo+PiBjb250ZW50 cyBmb3IgRlBBIHJlZ2lzdGVyLiAgU2ltaWxhcmx5LCBNQVhfUkVHSVNURVJf U0laRSBpcyB1c2VkIHRocmVlDQo+PiB0aW1lcyBpbiBhYXJjaDY0LXRkZXAu YywgYWxsIG9mIHRoZW0gY2FuIGJlIHJlcGFsY2VkIGJ5IFZfUkVHSVNURVJf U0laRS4NCj4+IEFsc28sIE1BWF9SRUdJU1RFUl9TSVpFIGNhbiBiZSByZXBs YWNlZCBieQ0KPj4gSTM4Nl9NQVhfUkVHSVNURVJfU0laRSBpbiBpMzg2LXRk ZXAuYy4gIEkgd291bGQgbGlrZSB0byBleGFtaW5lIHRoZQ0KPj4gdXNhZ2Vz IG9mIE1BWF9SRUdJU1RFUl9TSVpFIGluIGVhY2ggdGFyZ2V0LWRlcGVuZGVu dCBjb2RlLCBhbmQNCj4+IHJlcGxhY2UgTUFYX1JFR0lTVEVSX1NJWkUgd2l0 aCBrbm93biBjb25zdGFudHMgYXMgbXVjaCBhcyB3ZSBjYW4uDQo+PiBJIGRv bid0IHRoaW5rIGFueW9uZSBoYXMgb2JqZWN0aW9ucyBvbiByZXBsYWNpbmcg b25lIGNvbnN0YW50DQo+PiBNQVhfUkVHSVNURVJfU0laRSB3aXRoIG90aGVy IHNtYWxsZXIgY29uc3RhbnRzIDopDQo+PiANCj4+IFRoZW4sIGxldCB1cyBk aXNjdXNzIGhvdyB0byByZW1vdmUgTUFYX1JFR0lTVEVSX1NJWkUgZnJvbQ0K Pj4gYXJjaC1pbmRlcGVuZGVudCBjb2RlIGFmdGVyIGFsbCBhYm92ZSBpcyBk b25lLg0KPj4gDQo+IA0KPiArMS4NCj4gDQo+IFRoYW5rcywNCj4gUGVkcm8g QWx2ZXMNCj4gDQoNCklmIHNvbWVvbmUgY2FuIG9rIHRoZSBjb21tb24gcGF0 Y2gsIHRoZW4gSeKAmWxsIG1ha2UgYSBzZWNvbmQgcGF0Y2ggd2l0aCB0aGUN CnJlcGxhY2VtZW50IG9mIGFsbCByZW1haW5pbmcgdXNlcyBvZiBNQVhfUkVH SVNURVJfU0laRSBpbiBjb21tb24gY29kZS4NCkVuc3VyaW5nIGl04oCZcyBu b3QgdXNlZCBpbiBjb21tb24gY29kZSB3aWxsIGFsbG93IG1lIHRvIGNvbnRp bnVlIG1vdmluZyB3aXRoIHRoZQ0KYWFyY2g2NCBTVkUgY29kZS4NCg0KDQpU aGVyZSBhcmUgcXVpdGUgYSBsb3Qgb2YgYXJjaCBzcGVjaWZpYyBmdW5jdGlv bnMgd2hlcmUgd2UgaGF2ZSBhIHJlZ2lzdGVyIG51bWJlcg0KZnJvbSB3aGlj aCB0aGUgcmVnaXN0ZXIgc2l6ZSBjb3VsZCBiZSBleHRyYWN0ZWQuICBFZzoN Cg0Kdm9pZA0KU09NRUFSQ0hfcHNldWRvX3JlZ2lzdGVyX3dyaXRlIChzdHJ1 Y3QgZ2RiYXJjaCAqZ2RiYXJjaCwgc3RydWN0IHJlZ2NhY2hlICpyZWdjYWNo ZSwNCgkJCSAgICBpbnQgcmVnbnVtLCBjb25zdCBnZGJfYnl0ZSAqYnVmKQ0K ew0KICBnZGJfYnl0ZSByYXdfYnVmW01BWF9SRUdJU1RFUl9TSVpFXTsNCg0K DQpUaGlzIGNvdWxkIGJlY29tZToNCg0Kdm9pZA0KU09NRUFSQ0hfcHNldWRv X3JlZ2lzdGVyX3dyaXRlIChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXJjaCwgc3Ry dWN0IHJlZ2NhY2hlICpyZWdjYWNoZSwNCgkJCSAgICBpbnQgcmVnbnVtLCBj b25zdCBnZGJfYnl0ZSAqYnVmKQ0Kew0KICBnZGJfYnl0ZSBidWZbU09NRUFS Q0hfTUFYX1JFR0lTVEVSX1NJWkVdOw0KDQoNCk9yOg0KDQp2b2lkDQpTT01F QVJDSF9wc2V1ZG9fcmVnaXN0ZXJfd3JpdGUgKHN0cnVjdCBnZGJhcmNoICpn ZGJhcmNoLCBzdHJ1Y3QgcmVnY2FjaGUgKnJlZ2NhY2hlLA0KCQkJICAgIGlu dCByZWdudW0sIGNvbnN0IGdkYl9ieXRlICpidWYpDQp7DQogIHN0ZDo6dmVj dG9yPGdkYl9ieXRlPiBidWYgKHJlZ2lzdGVyX3NpemUgKGdkYmFyY2gsIHJl Z251bSkpOw0KDQoNCkkgc3VzcGVjdCBwZW9wbGUgd2lsbCB3YW50IHRoZSBm aXJzdCBhcHByb2FjaD8gSXQgd2lsbCByZXN1bHQgaW4gcXVpdGUgYSBmZXcg bmV3DQpkZWZpbmVzIC0gQUxQSEFfTUFYX1JFR0lTVEVSX1NJWkUsIFBQQ19N QVhfUkVHSVNURVJfU0laRSBldGMgZXRjLg0KDQoNCkFsYW4uDQoNCg== >From gdb-patches-return-136720-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Feb 03 16:13:45 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 34432 invoked by alias); 3 Feb 2017 16:13:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 34359 invoked by uid 89); 3 Feb 2017 16:13:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Feb 2017 16:13:42 +0000 Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2559B83F3E; Fri, 3 Feb 2017 16:13:42 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id A2E8E6F038; Fri, 3 Feb 2017 16:13:40 +0000 (UTC) Subject: Re: [PATCH 1/2] This patch fixes GDBServer's run control for single stepping To: Antoine Tremblay , Yao Qi References: <20161129120702.9490-1-antoine.tremblay@ericsson.com> <20170127150139.GB24676@E107787-LIN> Cc: "gdb-patches@sourceware.org" From: Pedro Alves Message-ID: <2255ed6f-a146-026c-f871-00e9a33dfcf0@redhat.com> Date: Fri, 03 Feb 2017 16:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-02/txt/msg00097.txt.bz2 Content-length: 1471 On 01/30/2017 01:28 PM, Antoine Tremblay wrote: >> We don't change anything when setting breakpoint inside IT block. > > Well that's a problem if we write a 32 bit thumb2 breakpoint aligned on > 2 bytes like discussed before. Can we restrict the stopping-all-threads to the case that needs it, only? An optimization that would avoid this would be to use a hardware watchpoint/breakpoint (if available) for single-stepping. IIRC, you can ARM a breakpoint (or was it a watchpoint) on ARM for triggering when the PC is different from the current PC (or really, some specified address). In IT blocks, this would probably make the thread stop on instructions that aren't really executed (e.g., the then/else branches when the condition is correspondingly false/true), unlike the current solution where breakpoint instructions are not executed by the CPU when it falls on an instruction that isn't executed (because the breakpoint opcode we use it just some magic invalid instruction, node the BKPT instruction), but I think that when the thread stops, and we're stepping an IT block, we could look at the status registers and decide whether to single-step again. TBC, I'm not suggesting that we need to do that right now. The emulation solution discussed on the lkml thread made me thing of displaced stepping -- the ARM implementation emulates some instructions. I wonder whether displaced stepping over IT blocks is already handled correctly. Thanks, Pedro Alves