From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2074.outbound.protection.outlook.com [40.107.22.74]) by sourceware.org (Postfix) with ESMTPS id 8FC013857C53 for ; Mon, 10 Aug 2020 08:52:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8FC013857C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Alan.Hayward@arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hzh/WJZ41OO2TK8si6T6VLRE7GkgIK3I27/VmPY+wyI=; b=CQiaJHu12ekDcFV7wUU/s03IyOgzD4k7q1M+uMTP0U7eIPx5JetG7JY2Ub1tZ5K9Dheuz3KHETVvAV+0lBDLNX5GMdqv7PnxV74CabYv9ijOv87NY0H3oWkVqn2/kLgUap3RrSlHfwRvA2K/6SKl91cy+/Vb9A9RVvagdGVhkj8= Received: from AM5PR0602CA0016.eurprd06.prod.outlook.com (2603:10a6:203:a3::26) by AM0PR08MB5425.eurprd08.prod.outlook.com (2603:10a6:208:17d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.15; Mon, 10 Aug 2020 08:52:20 +0000 Received: from AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:a3:cafe::87) by AM5PR0602CA0016.outlook.office365.com (2603:10a6:203:a3::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.17 via Frontend Transport; Mon, 10 Aug 2020 08:52:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; sourceware.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT039.mail.protection.outlook.com (10.152.17.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.16 via Frontend Transport; Mon, 10 Aug 2020 08:52:20 +0000 Received: ("Tessian outbound 7a6fb63c1e64:v64"); Mon, 10 Aug 2020 08:52:20 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1059a6947abd2dce X-CR-MTA-TID: 64aa7808 Received: from 34445f615986.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B2E10BDD-1485-4169-8A2B-55A99173CD72.1; Mon, 10 Aug 2020 08:52:15 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 34445f615986.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 10 Aug 2020 08:52:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DnhLcAew7qZJkD8v39rjgRBZmTUfy8Qqm4N+srCLYR4+Yy7j9IyMTeL+4AFnh5FtgNYa9S4O2/VJE60nOd1bnByhdVILahDtl/poYJOxeoKMs1v5fJiP7ep9wyPcwSEM4lzUYp12XQOaJF8woLL4iNBXTK3riwD1N0wQMv/uzUjJtSL0ZNABqla6bsyIZOA3g5awkC51A3sdiEvPRhDYy/jclo3BKlY0j2GeMxZXnuX9updRz4xjzk3KknicohrQVvIAqDxqQ3iZ+1XR7LJOAhoHSofPo5Zs3rAP8rRGbFRU6nAODFfYCUCfnVyLyHCuHjU6N8DVqygOQQqWgqp8Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hzh/WJZ41OO2TK8si6T6VLRE7GkgIK3I27/VmPY+wyI=; b=gCzG7nKaFQ1PdnoyLEAaSrRqXDPqcQOwwRk6kWcgdzbaPoc9jHi9M3YyMA4lLd2uki2fFuVBqBWerirJtlnUxCVYZaoC+l4NVfVkhbwizXOBKLdjqNO9L62EZxzVd3gCQ7N01pW/1TaY4GSXdfTJRNXqpnpi6iidovVoT2MCf9EnZKol/AOm7oq2qTlDIr5VzW1JKoC/Y4RfMdYhlBUuocxOuq9EmHdkID50fZD3cNnK2I+96WsHaXQDaeKFlL6gb8k7humFGNw0v2VTE0isjHR7NYypTpN7QAiVgj8Mw9lKf5Y66jN/djXfeawR19CkDMBzvFF4+CTbR8cytGipNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hzh/WJZ41OO2TK8si6T6VLRE7GkgIK3I27/VmPY+wyI=; b=CQiaJHu12ekDcFV7wUU/s03IyOgzD4k7q1M+uMTP0U7eIPx5JetG7JY2Ub1tZ5K9Dheuz3KHETVvAV+0lBDLNX5GMdqv7PnxV74CabYv9ijOv87NY0H3oWkVqn2/kLgUap3RrSlHfwRvA2K/6SKl91cy+/Vb9A9RVvagdGVhkj8= Received: from AM6PR08MB3957.eurprd08.prod.outlook.com (2603:10a6:20b:a2::14) by AM7PR08MB5333.eurprd08.prod.outlook.com (2603:10a6:20b:104::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.18; Mon, 10 Aug 2020 08:52:14 +0000 Received: from AM6PR08MB3957.eurprd08.prod.outlook.com ([fe80::95d8:11b:827f:a517]) by AM6PR08MB3957.eurprd08.prod.outlook.com ([fe80::95d8:11b:827f:a517%4]) with mapi id 15.20.3261.024; Mon, 10 Aug 2020 08:52:14 +0000 From: Alan Hayward To: Luis Machado CC: gdb-patches , nd Subject: Re: [PATCH] [AArch64] Fix incorrectly-defined SVE macro Thread-Topic: [PATCH] [AArch64] Fix incorrectly-defined SVE macro Thread-Index: AQHWbNxGBoD8rYSkykOGQ1Fviqb0DakxDVyA Date: Mon, 10 Aug 2020 08:52:13 +0000 Message-ID: <0C61C5A0-A1DD-48B8-874A-96ED095F14F7@arm.com> References: <20200807170003.1761-1-luis.machado@linaro.org> In-Reply-To: <20200807170003.1761-1-luis.machado@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3608.80.23.2.2) Authentication-Results-Original: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.99.251] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4330f01b-dc85-49d4-9bc2-08d83d0ab16d x-ms-traffictypediagnostic: AM7PR08MB5333:|AM0PR08MB5425: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:7691;OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fLbrPO5SJZIKsAEfgXgU9OCPaKRjGWjzsONbfZcqDBbpp/zBNYhl4IqqcqtbWYb0IwElMILxTA55/Y5g6R9Pi5ZZrXidqErkspG0d0gZwRqLwwK44iY8przCyaNryle2QIjE1uBM5rVyDQlnV3x+4N37B7mxUdFodf4cCAztaVlmQuf7QcIt2V8q4nInhUVUamE6FuR9lc1QO9iHAMOvbsvyEyWbu5j6ji6aCLo/3ClOOSrozAhzGpcHmk6yxlP7B1C/W61Mrw8pTWp1+9wOnBDgbU5PT4ZWQwwX0nibZ/PQmiCe64C6JFXaTdAZjEH5EMarAl/3tKjQRi/uxH6mzuYE5kbJmpSL/aLugmyGN6ckH9j6tzc8DHpote9mYGt5BpvzO1iG5gzMNYyztU8vNg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR08MB3957.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(376002)(396003)(346002)(136003)(39860400002)(6512007)(71200400001)(36756003)(316002)(66556008)(66476007)(66446008)(64756008)(54906003)(8676002)(5660300002)(6916009)(83380400001)(6506007)(66946007)(76116006)(91956017)(53546011)(478600001)(86362001)(186003)(8936002)(4326008)(2616005)(26005)(966005)(6486002)(33656002)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Unp5ElsJKuaGPOU5oXFa/+dZfhf3lcRHm3k+6UEvhzA8KY+iDV1X6FHRsG0lOAdJONgx/K2+Yo9KzwE92Fga9LEgYs9Fg5ndCek33fiOw5oRyXVHvJ41cLwxCGxOEZJFHKrEmjWTK65tdXK7PsrpK3VIAoAllYUnRMUo2NYg7jSUMYPoD2IAxUFwMWwlgpFV5b1y4QdxLw6hKfKxchYVBX1PxxK8ggSEb4f2Sr6JHNNvAf4SqDSGQXiemGyJ9xu5igBLD5oyOXoDZSi6vBAPbRhf2eRRHoZvukE4sdIvGXPVG4c7tA0R31lV7HGgpZEExtFyinwfDc3eFo691y0TN6LVnc4nKw9Zu+ZKvH3+iM35Dv+hfjFtxc0MjdL++ylqx3Gx3M8hiP9DMQIohatc3yrtvMcMM+7Tj32Rp3H5oBFvh2pwea1rkMjWf2TJ/0kxuHYJ6+ZQtCVl7WJ+3YBjsMKxt4/pTfcJDDgZ7IAPk5hmDv4FQx8BkU++3dBsq+VQq4ItCw/vU3YIHh/iiaBPCB7yNYtkw7ZkpzKZ0Q726j5vHivmHLl4HFDfAxa1TugoTL8xSuy6C/h6IY3e2BVM/3yCz4r8bhFKBdorC9JsrE5B6S/XZK9mTWzJ5pa5eidXZlfI7uAZcv1g7U7kUTlILA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: <4CD28E604577C449AED2BA7ACE6216E3@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5333 Original-Authentication-Results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: eefc54a7-332d-41ea-2efd-08d83d0aad62 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: an5P9OYqo7WToQhUt9n7QviC2JzV2scyknP5mgoCmk7/LRcmDQR6zO2CDuO06UJMb6Y3F64ksgC8vipG3r7yHOI0dR6Yxk9Fr+8vXTEsMcIOt93egKxEZ6coYt2TEc8xovRUDvV2A/wNJUzo5POSeV9q7LG5vyC7WUkUK9hnK0WiaVLlazdtJm46C9GeBdB3KMd3EQi6cNPgLx12RxP2qEX44URFkas6yxsqBgekjR2gUiypwda69a6XbrS7tm5og/lQ96YAdmvdKxV3Ox3oyAtrHYSE8KDewjDES+jkOvkQxBkZxXhoMgDATRwIm06ykB1kEZBHgWIj9dZNfg/suNtDGu7xAxEbuEInipTtCwbrFO3oVu5MR0JtT+2kuYAhcC7VS4iguvCBFtld/5s++R7nUZq2CHRRE2Z90VCw4RlxgVVs2ITtOEoieyPXHmPZxZmbVochfMKifR8IVbuUlA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(136003)(346002)(376002)(396003)(39860400002)(46966005)(478600001)(86362001)(966005)(26005)(70206006)(53546011)(6506007)(70586007)(82740400003)(82310400002)(356005)(6486002)(47076004)(5660300002)(81166007)(83380400001)(8936002)(8676002)(6512007)(316002)(36906005)(4326008)(186003)(336012)(54906003)(6862004)(36756003)(2616005)(2906002)(33656002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2020 08:52:20.8063 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4330f01b-dc85-49d4-9bc2-08d83d0ab16d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5425 X-Spam-Status: No, score=-14.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2020 08:52:24 -0000 > On 7 Aug 2020, at 18:00, Luis Machado wrote: >=20 > The kernel has fixed this here: >=20 > https://lore.kernel.org/patchwork/patch/1029011/ >=20 > We should do the same for GDB, which is still carrying an incorrect > definition of the macro. As stated in the kernel patch thread, this does= n't > actually change things because, luckily, the structs are of the same size= . >=20 Ouch. Good find. > YYYY-MM-DD Luis Machado >=20 > * nat/aarch64-sve-linux-sigcontext.h (SVE_PT_REGS_OFFSET): Use > struct user_sve_header instead of struct sve_context. > --- > gdb/nat/aarch64-sve-linux-sigcontext.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/gdb/nat/aarch64-sve-linux-sigcontext.h b/gdb/nat/aarch64-sve= -linux-sigcontext.h > index 94fb1eca9c..52c5982608 100644 > --- a/gdb/nat/aarch64-sve-linux-sigcontext.h > +++ b/gdb/nat/aarch64-sve-linux-sigcontext.h > @@ -166,7 +166,7 @@ struct user_sve_header { >=20 > /* Offset from the start of struct user_sve_header to the register data *= / > #define SVE_PT_REGS_OFFSET \ > - ((sizeof(struct sve_context) + (SVE_VQ_BYTES - 1)) \ > + ((sizeof(struct user_sve_header) + (SVE_VQ_BYTES - 1)) \ Matches the Kernel change exactly. So, approved! > / SVE_VQ_BYTES * SVE_VQ_BYTES) >=20 > /* > --=20 > 2.17.1 >=20