From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-83730-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30015 invoked by alias); 16 Sep 2011 15:41:57 -0000
Received: (qmail 30001 invoked by uid 22791); 16 Sep 2011 15:41:56 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=AWL,BAYES_00,TW_CL
X-Spam-Check-By: sourceware.org
Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Sep 2011 15:41:42 +0000
Received: from localhost (localhost [127.0.0.1])	by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id A2DB0CB000F;	Fri, 16 Sep 2011 17:41:43 +0200 (CEST)
Received: from mel.act-europe.fr ([127.0.0.1])	by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024)	with ESMTP id dIwrDDM2hUty; Fri, 16 Sep 2011 17:41:33 +0200 (CEST)
Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67])	(using TLSv1 with cipher AES128-SHA (128/128 bits))	(No client certificate requested)	by mel.act-europe.fr (Postfix) with ESMTP id 5DF37CB026E;	Fri, 16 Sep 2011 17:41:33 +0200 (CEST)
Subject: Re: [RFA] Preliminary work in fork_inferior
Mime-Version: 1.0 (Apple Message framework v1244.3)
Content-Type: text/plain; charset=iso-8859-1
From: Tristan Gingold <gingold@adacore.com>
In-Reply-To: <201109161557.12334.pedro@codesourcery.com>
Date: Fri, 16 Sep 2011 18:25:00 -0000
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <0B3BDB0A-BD4D-4360-B1C8-CC24A1948B14@adacore.com>
References: <E9D2564E-6E60-4938-B358-32B2DA122E08@adacore.com> <201109161419.55173.pedro@codesourcery.com> <49D8FDB6-8E7E-46F1-B2FE-DABF6697B87D@adacore.com> <201109161557.12334.pedro@codesourcery.com>
To: Pedro Alves <pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-09/txt/msg00310.txt.bz2


On Sep 16, 2011, at 4:57 PM, Pedro Alves wrote:

> On Friday 16 September 2011 15:47:19, Tristan Gingold wrote:
>>=20
>> On Sep 16, 2011, at 3:19 PM, Pedro Alves wrote:
>>=20
>>> Thanks, this is okay.
>>>=20
>>> On Friday 16 September 2011 13:28:59, Tristan Gingold wrote:
>>>> +      /* If we get here, it's an error.  */
>>>>      if (shell)
>>>>       {
>>>> -         execlp (shell_file, shell_file, "-c", shell_command, (char *=
) 0);
>>>> -
>>>> -         /* If we get here, it's an error.  */
>>>>         fprintf_unfiltered (gdb_stderr, "Cannot exec %s: %s.\n", shell=
_file,
>>>>                             safe_strerror (errno));
>>>=20
>>> I wouldn't mind merging the "Cannot exec" bits of both branches as well,
>>> always printing the whole argv.
>>=20
>> Ok, so more cleanup.  Something like that ?
>=20
> Looks greak, thanks!  Please apply.

Thanks, now committed.

Tristan.