From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-107915-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23529 invoked by alias); 4 Dec 2013 08:43:46 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 23518 invoked by uid 89); 4 Dec 2013 08:43:45 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=2.1 required=5.0 tests=AWL,BAYES_50,RDNS_NONE autolearn=no version=3.3.2
X-HELO: smtp.eu.adacore.com
Received: from Unknown (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 04 Dec 2013 08:43:45 +0000
Received: from localhost (localhost [127.0.0.1])	by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id D94FB26C0338;	Wed,  4 Dec 2013 09:43:36 +0100 (CET)
Received: from smtp.eu.adacore.com ([127.0.0.1])	by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024)	with ESMTP id 8V5LbHc6MJ_z; Wed,  4 Dec 2013 09:43:36 +0100 (CET)
Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67])	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))	(No client certificate requested)	by smtp.eu.adacore.com (Postfix) with ESMTPSA id A9A5B26C0325;	Wed,  4 Dec 2013 09:43:36 +0100 (CET)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1822\))
Subject: Re: [RFA] Allow Windows UNWIND_INFO version 2.
From: Tristan Gingold <gingold@adacore.com>
In-Reply-To: <529E274D.607@redhat.com>
Date: Wed, 04 Dec 2013 08:43:00 -0000
Cc: Joel Brobecker <brobecker@adacore.com>, "<gdb-patches@sourceware.org> ml" <gdb-patches@sourceware.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <0AE4307E-11F4-48EC-91DD-B03A7B1F2964@adacore.com>
References: <1386070345-8237-1-git-send-email-brobecker@adacore.com> <529E274D.607@redhat.com>
To: Pedro Alves <palves@redhat.com>
X-IsSubscribed: yes
X-SW-Source: 2013-12/txt/msg00119.txt.bz2


On 03 Dec 2013, at 19:47, Pedro Alves <palves@redhat.com> wrote:

> On 12/03/2013 11:32 AM, Joel Brobecker wrote:
>> @@ -696,7 +697,17 @@ amd64_windows_frame_decode_insns (struct frame_info=
 *this_frame,
>> 	return;
>>=20
>>       end_insns =3D &insns[codes_count * 2];
>> -      for (p =3D insns; p < end_insns; p +=3D 2)
>> +      p =3D insns;
>> +
>> +      /* Skip opcodes 6 of version 2.  This opcode is not documented.  =
*/
>> +      if (PEX64_UWI_VERSION (ex_ui.Version_Flags) =3D=3D 2)
>> +	{
>> +	  for (; p < end_insns; p +=3D 2)
>> +	    if (PEX64_UNWCODE_CODE (p[1]) !=3D 6)
>> +	      break;
>> +	}
>=20
> I'd consider merging with the existing loop, so that
> we print the opcodes when frame debug is enabled.

Not sure this is a good idea.  You can use objdump -p if you want to view t=
he opcodes.

But this opcode was also used in version 1, and in version 2 appears only b=
efore all other
opcodes.

Tristan.