From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by sourceware.org (Postfix) with ESMTPS id 68232385E006 for ; Fri, 27 Mar 2020 17:05:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 68232385E006 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1585328707; bh=4kruQLfqZLnwdl/dq77mp0Uu3v27+2XSAsBUPqiSCxM=; h=X-UI-Sender-Class:To:Cc:References:From:Subject:Date:In-Reply-To; b=RInT7qUN7Nvm2Z4V03eWCw4L+qUMk+UD8GS4oY9WEt51tA338xbOmAOrw0EueZyDD e6O20H/Iu0C0CDAC1x7wXtQiyb0yS2wGvooO/iu6WybRKEAGv4eJuolU3MKKrJTQ41 RuqyFCg2kDURnVUxmBkhqE4tMMjMiPJJeAOkdnDg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1Mw9Q6-1jYaQB1HZE-00sAYj; Fri, 27 Mar 2020 18:05:07 +0100 To: John Baldwin , gdb-patches@sourceware.org Cc: tom@tromey.com References: <20200316181710.7542-1-n54@gmx.com> <20200320172739.26705-1-n54@gmx.com> <0e8e2d3c-aaa7-7a1f-6685-cf15753e8bca@gmx.com> <39c2ef17-89b2-7c7e-e806-0085de678c5b@FreeBSD.org> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Subject: Re: [PATCH v3] Add support for "info auxv" on NetBSD Message-ID: <09e82a84-db6d-3fed-cf4e-67208cb14ff3@gmx.com> Date: Fri, 27 Mar 2020 18:04:00 +0100 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <39c2ef17-89b2-7c7e-e806-0085de678c5b@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:UonxDW+tAZlersNptcQpioOiwEHesLVLrlBh5hEMQHw53j7ruXI W3TZlddQm88kxHiXxKmazjvi8rwsk+0i5j8zCkvEtSW+nfw4YP4ZBOH9WoEw702EwTX2QxR ew9+TYxNsi090PWptO7x/rrsMxsjga6+UGSVTqAD0NSXQbgcsZogcUmy3/y3tXbgKansBqc SPZRxQjWEEZeVC1Z/Ywrw== X-UI-Out-Filterresults: notjunk:1;V03:K0:CSp5/iPi7A0=:CwlzickVUAd8ntfabwrJ98 dncqJtkOSYTufKkJDGzw7kjgYYXAH3JBg0KvbdY0MIlgJejI42GaRi3rMYfmvL8Pv9JCe1T6S oVnbUw0RVzHaAeCvOiTllhZVoj6gXkW6RgKhvhBFzVr0zlHSRLe3NfCEK4ySfRl641/G69QdK VEzhwXCLNAznHyzl33/C2xCRvEZS2+6IHVe5Dbb7Ku39kR1Qa5ZqFeGLVn4wknEWfTxhfw6dz vVKUnjEyQdl2a+OT/lX66WiWGUaXHeifAt7z4zxDUsdptRxn4/722V5s85k9b6CFg2aj6LPgM 6u6P1vp6D8M6NcNdGyaxGkNl10UnT38JTdSqleFGmmLNcmH3GLd1zFX/LZGxZZRnsGtJqyQQu 4ClewkEyBBgLYJ7/4CukYsr9qm5mz6ECJnToJzc6rg6QQNh8Bb2WCQUADEdmc40JyaNpMJtl2 HhL7nmecDN7RhKz3jGvGIjTKPWw2l2UZQFtS/ku4D/ZmL+BOpwmObVC5PYCQryXOqxOQoPDTR KNYcgQ75AT7hjPqqNJVQ4QFVYl9hjktHtvGQaXXVDGM+pqcx/mEWNMud9r6Y9XazKs9UK98Yj QXNEBVDV6cU1Xi5tomfYVLwFX6emSqgas70r3kYzFXnHtejpAeJNbmP6kdFsGbGjmpzPK8Xtw SUoiwPSTW8RVa8Uw+XIoF3gmBwv2FChvqodkRMsxiubP/ym95znAN3OqekUvAEr1l5V8Hi6Cj dufGFzrUYbp2ybVWu1FtdWOPw2n5nYcP6j5H26UchF8Y1ztfcWGErmOUYIWbWKcTew9WbtHKt ++PJo114X88iiEFe4vgkxwiYZCqcJYe0klMagexEJITcEKmHL/kAeTpGQ0VRQ1+hmJ+6KmB6p iB1/kE6wE43SEB/85xMG1e3asv5T1CWhheHnijoI+dI+QAYRrg9kROejCcZeQJEB1g1f59uyZ +e1QlhP5bkgNcglnuXOMF8D1p/OaqqJqlQECyJYy8vsI66DRH56DGb97Newhp+yIv9NJ7CWR2 lzZY4DZgmnC5FkPVIfo+CjygrhBBNaltKZ7GvencAFBPibwGMqZAAEhyCZE8KesnL8XjyrkO2 DZTqrE/R+PQCf/tCywLGDfFB5SmecwX1iH0fNO6OAKXnxEL597HsuWsir8ZcmJavGgjUu0noC gp0Wd68hCkm/ZyvYtW1znbGkQH/QkBGgF+0Ht/gtZ4R5sdCxe0nAaR8wR/LmKdr7a08JA= X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2020 17:05:36 -0000 On 27.03.2020 17:31, John Baldwin wrote: > On 3/26/20 4:26 PM, Kamil Rytarowski wrote: >> Ping? >> >> On 20.03.2020 18:27, Kamil Rytarowski wrote: >>> Register nbsd_auxv_parse() that overloads the default (Linux-style) >>> AUXV parsing. On NetBSD the type parameter is defined as int32_t >>> for all architectures. > > I would tone down some of the rhetoric. FreeBSD uses the default AUXV > parsing, and I think Solaris does as well, so describing it as Linux-onl= y > isn't very accurate. > It is phrases as Linux-style, not Linux-only. Linux-style is considered as the default one and other OSs have to tune it= . > (Similarly, I think the earlier reviews I saw around ptrace() claimed th= at > NetBSD was the only OS to use LWPs with ptrace() in the log messages in > effect which isn't really true as both Solaris and FreeBSD use LWPs > happily with ptrace(), just using a different convention.) > The pair of (PID+LWP) for getters and setters of registers (among certain other ptrace operations) is NetBSD style ptrace(2) API design. This leads to the point that NetBSD is currently the only OS where get_ptrace_pid() is not compatible (at leat in the current form). >>> } >>> + >>> +/* NetBSD-specific parser for AUXV data with. NetBSD follows the ELF >>> + specification, contrary to some other ELF Operating Systems. */ > > I would also tone this down a bit, and at least reference the correct > specification. The ELF spec doesn't define the layout of auxv_t. The > per-architecture psABI documents do. Also, just saying that you follow > the spec doesn't help. I would suggest something like: > > /* NetBSD-specific parser for AUXV entries. NetBSD always uses an int > to store the type as defined in the SVR4 psABI specifications rather > than long as assumed by the default parser. */ > This is toned down compared to obsd-tdet.c, that says: /* Unlike Linux, OpenBSD actually follows the ELF standard. */ OK, is this patch fine after rephrasing the above texts?