From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130083 invoked by alias); 25 Oct 2016 14:05:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130069 invoked by uid 89); 25 Oct 2016 14:05:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Oct 2016 14:05:00 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EE046683F9; Tue, 25 Oct 2016 14:04:58 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9PE4veL030205; Tue, 25 Oct 2016 10:04:58 -0400 Subject: Re: [RFA 2/2] Make some dwarf_expr_context methods pure virtual To: Tom Tromey References: <20161024122802.AE37B11C284@oc8523832656.ibm.com> <87y41damyl.fsf@tromey.com> <871sz4a6co.fsf@tromey.com> Cc: Ulrich Weigand , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <09e0354b-b0cf-11e9-de81-05cd77349805@redhat.com> Date: Tue, 25 Oct 2016 14:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <871sz4a6co.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00702.txt.bz2 On 10/25/2016 02:47 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> Looks like -Wnon-virtual-dtor was removed from (guessing) -Wall > Pedro> at some point. > > Perhaps it's worth adding it explicitly in configure.ac. > (Though I don't know why it was removed from -Wall, so maybe it's not > always appropriate, for reasons I don't know.) Yeah, cross my mind too. I'd like to understand why it was removed first. (I don't know whether it used to be in -Wall, or default, or enabled along some other -Wfoo option.) I found these: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=7302 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=15214 but those fixed false positives. I think that would have supported enabling by default. Sounds like something else might have been identified. Thanks, Pedro Alves