From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90854 invoked by alias); 27 Feb 2020 19:06:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90846 invoked by uid 89); 27 Feb 2020 19:06:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (205.139.110.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Feb 2020 19:06:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582830413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=logIIII0y95SVg4NV6BHjcYbMU3ssTMPSUWfo4kT3/Q=; b=SS5UnBuvicOSqgGHxfXp1cNmAoi6wgsIyeRe+zGeZtq/E/rvJr9liHC48bTUhD4hmFGWnt XLRf2URvjUbBt/WCPpc1OGh8eBL+gxPjGQ3xZxKMpPRf7iVXVYwiGY5Mf/4LHVN5ji1+F4 VlNJqYXdOp2gFuG4p0FXqjsjwiAU92k= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-y9UH-HF8P66rEd9KuS3b3w-1; Thu, 27 Feb 2020 14:06:51 -0500 Received: by mail-wr1-f71.google.com with SMTP id 72so235999wrc.6 for ; Thu, 27 Feb 2020 11:06:51 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id s139sm9159257wme.35.2020.02.27.11.06.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Feb 2020 11:06:48 -0800 (PST) Subject: Re: [PUSHED] gdb: Use std::abs instead of abs on LONGEST types To: Andrew Burgess , gdb-patches@sourceware.org References: <20200227164651.13723-1-andrew.burgess@embecosm.com> From: Pedro Alves Message-ID: <09b7ad54-6c4f-922e-9a72-9e3d26603aec@redhat.com> Date: Thu, 27 Feb 2020 19:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200227164651.13723-1-andrew.burgess@embecosm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg01018.txt.bz2 On 2/27/20 4:46 PM, Andrew Burgess wrote: > Use std::abs so that we get the C++ overloaded version that matches > the argument type instead of the C abs function which is only for int > arguments. Note that stdlib.h/stdmath.h are supposed to provide the overloads in the global namespace as well; the standard requires it. Older GCCs got that wrong (e.g. 4.8), but more modern GCCs get it right. Just a FYI, the patch is fine. > > There should be no user visible change after this commit. > > gdb/ChangeLog: > > * gdbtypes.c (create_array_type_with_stride): Use std::abs not > abs. Thanks, Pedro Alves