From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Kq1BCxhVumAtSAAAWB0awg (envelope-from ) for ; Fri, 04 Jun 2021 12:30:16 -0400 Received: by simark.ca (Postfix, from userid 112) id 1FE9C1F163; Fri, 4 Jun 2021 12:30:16 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 481A21E01F for ; Fri, 4 Jun 2021 12:30:15 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3485B399E046 for ; Fri, 4 Jun 2021 16:30:14 +0000 (GMT) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by sourceware.org (Postfix) with ESMTPS id 32B55385E036 for ; Fri, 4 Jun 2021 16:29:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 32B55385E036 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f51.google.com with SMTP id u7so4464421wrs.10 for ; Fri, 04 Jun 2021 09:29:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JVAsN8ukOb7xYjV4kfWodTcFeMiFp1l45RSSz4ymkk0=; b=pMb/nTgXGTGRSRBpklV7OOp9ye/jaL5IWpmEk2V40Qy38v8r9PN7Pk9jY7aDb7JL7p R6V9ju+UDWCJ0ZaTdVusryplM0JvBMaUqzUKQeD0lIEfXYG1x2YDrHWAg+G8WrACUWda VvwLXbcbvNfWbqQGj06C68prdbeJxEP0f0hhPmC4XAEZlR+QfcLAt/NPVI/xtjzUzC4K AQBwVE35o03N4rty/3R1Gt2RWsOvMy1OjDB8pwAaYf+kKUadyLoS4SdAS763beuS+tTK MnJX0kATaEsCP+4OWncZOGDWef/9X2dlt4Xp7rLAr7rvL8BsMBfLcp2aY+AOyLQ1M886 OMrA== X-Gm-Message-State: AOAM533s+Kv+J8DUyK+pfnDsR17Wi8Tiqk5FhiRL/B3/kF4CV4KRypxp hpa5Co5XDwUXxZeLozgbOGo= X-Google-Smtp-Source: ABdhPJzSeFtLQqtA/QsO5q8weKpDF+r+eQfKw4Kbm1XKRG+cM28Pr8651vlfUJh/GhPTTli9oI9I8Q== X-Received: by 2002:adf:e950:: with SMTP id m16mr4803941wrn.249.1622824192297; Fri, 04 Jun 2021 09:29:52 -0700 (PDT) Received: from ?IPv6:2001:8a0:f932:6a00:46bc:d03b:7b3a:2227? ([2001:8a0:f932:6a00:46bc:d03b:7b3a:2227]) by smtp.gmail.com with ESMTPSA id k8sm4331349wrp.3.2021.06.04.09.29.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jun 2021 09:29:51 -0700 (PDT) Subject: Re: [PATCHv3 1/2] Initial TUI mouse support From: Pedro Alves To: Hannes Domani , Hannes Domani via Gdb-patches , Tom Tromey , Joel Brobecker References: <20210603151453.15248-1-ssbssa.ref@yahoo.de> <20210603151453.15248-1-ssbssa@yahoo.de> <87r1hhoi03.fsf@tromey.com> <1760297979.5212997.1622816480782@mail.yahoo.com> Message-ID: <0936428e-80c4-c192-cdfd-817ff9bcfab0@palves.net> Date: Fri, 4 Jun 2021 17:29:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-06-04 4:20 p.m., Pedro Alves wrote: > On 2021-06-04 3:21 p.m., Hannes Domani via Gdb-patches wrote: >> Am Freitag, 4. Juni 2021, 15:51:27 MESZ hat Tom Tromey Folgendes geschrieben: >> >>>>>>>> "Hannes" == Hannes Domani via Gdb-patches writes: >>> >>> Hannes> Implements an overridable tui_win_info::click method whose arguments >>> Hannes> are the mouse coordinates inside the specific window, and the mouse >>> Hannes> button clicked. >>> >>> Hannes> And if the curses implementation supports 5 buttons, the 4th and 5th >>> Hannes> buttons are used for scrolling. >>> >>> Hannes> 2021-06-03  Hannes Domani  >>> >>> Hannes>     * ser-mingw.c (console_select_thread): Handle MOUSE_EVENT. >>> Hannes>     * tui/tui-data.h (struct tui_win_info): Add click function. >>> Hannes>     * tui/tui-io.c (tui_prep_terminal): Enable mouse events. >>> Hannes>     (tui_deprep_terminal): Disable mouse events. >>> Hannes>     (tui_dispatch_ctrl_char): Handle KEY_MOUSE. >>> Hannes>     * tui/tui.c (tui_disable): Disable mouse events. >>> >>> Looks good.  Thank you again. >> >> Pushed both, thanks. >> > > Yay, mouse support finally. Thank you! Unfortunately, now that I try it, it's broken for me. And it's broken in a very bad way -- I think this should block the release or be disabled until we figure out what's wrong. It definitely makes GDB unusable for me. The trouble is that now pressing anywhere on the screen with the mouse just results in weird characters being printed on the command line window (probably uninterpreted control sequences). That even prevents me from selecting text (something I do often) -- I wanted to do that to paste the results here. I even tried suspending GDB with ^Z to then copy the text, but that still leaves the mouse messed up. See this screenshot: https://i.imgur.com/bO7FKDO.png This was on Ubuntu 20.04. Pedro Alves