New failures on gdb.python/py-format-string.exp - unix/-m32 (was: Re: [PATCH v4] Add gdb.Value.format_string ())

Sergio Durigan Junior
2019-04-12T20:18:48Z

On Thursday, March 28 2019, Marco Barisione wrote:

> On 27 Mar 2019, at 20:16, Tom Tromey <tom@tromey.com> wrote:
>> I only have two nits with this patch. The rest looks very good, thank
>> you for doing this.
>
> Thanks!
>
> I’ve attached a patch which is identical to the previous one except for:
> * Indentation fixed;
> * The NEWS file update was moved to the “Since GDB 8.3” section;
> * Test fixed to not expect a stray space between a comma and a newline
> any more (as the original behaviour was fixed by Andrew Burgess a few
> days ago).

Hi Marco,

The new test FAILs when tested on x86_64 with -m32. I.e.,:

make check-gdb TESTS=gdb.python/py-format-string.exp RUNTESTFLAGS='--target_board unix/-m32'

The failures I'm seeing:

python print (gdb.parse_and_eval ('a_base_ref').format_string (deref_refs=True))
@0xffffbb98: {_vptr.Base = 0x80487a4 <vtable for Deriv+8>, a = 42, static a_static_member = 2019}
(gdb) FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: a_base_ref with option deref_refs: deref_refs=true
...
python print (gdb.parse_and_eval ('a_base_ref').format_string (deref_refs=True, static_members=False))
@0xffffbb98: {_vptr.Base = 0x80487a4 <vtable for Deriv+8>, a = 42}
(gdb) FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: a_base_ref with option deref_refs=True, static_members=False

Here is the BuildBot run:

https://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/12191

And the logs:

https://gdb-build.sergiodj.net/results/Fedora-x86_64-m32/52/52093e1b936fa4f3f8bb3868c5a44d0df25c8db4/

Let me know if you need help investigating these.

Thanks,

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible