From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id f/6AJJN6v2jaeDwAWB0awg (envelope-from ) for ; Mon, 08 Sep 2025 20:53:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1757379219; bh=vYx/lLPIsF2mDnUknXXxtAYkFlpgii0zei8XUyk85S0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=SxAk04VdZy93NvYa+o/7D6l0C0bKybaKkPprjSfC7Ma8J0IGkYAtP6RjGU/0qAkKo usfGfKj/hdDBgxa/3hMZpFEvoh6Nrhp2MvA+oOgngH4G5yqH3ECIywkuDwSTWxBQgc SwDAsK3KFkNO/gX6zQGaodqdg0eyiWLgQj9VJ8R8= Received: by simark.ca (Postfix, from userid 112) id 802F61E0BA; Mon, 08 Sep 2025 20:53:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=MUaljZIW; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 519291E047 for ; Mon, 08 Sep 2025 20:53:38 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B5F303858C55 for ; Tue, 9 Sep 2025 00:53:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B5F303858C55 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=MUaljZIW Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id B124D3858D1E for ; Tue, 9 Sep 2025 00:50:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B124D3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B124D3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757379026; cv=none; b=PhEUzc0Z/2ILFqociH+Aio4o/zKpkEDRK9jeAQDfsG9K1kGGsPjYG7F1b5zk7Ukdt9TpZmC0w51NAIaE84DV/wiW9hAauX/PFWMAByVDPnEVxXWksOqihbhMcOq0m1vaw9m8qhYYTeeMKxyORrmPHJn2e0H1hzp+OFImSeGcQIQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757379026; c=relaxed/simple; bh=vYx/lLPIsF2mDnUknXXxtAYkFlpgii0zei8XUyk85S0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=prrceda7VJMD3+v0TVCfyScSYKOw8yFu+I93Ul9YuA5iVGjHSsrAy+AuU/u+dscqojeIa4vGtElHXEbBQNASApTLA0sZizfvE+Upg9PHwCYQ9o81TQTmvsUvT6iwLm97kz2jBwbYyIiTuRELC9ph3Q6xo9QLp37pdiIvCXCIFHQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B124D3858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1757379026; bh=vYx/lLPIsF2mDnUknXXxtAYkFlpgii0zei8XUyk85S0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=MUaljZIWLXC9HqUDHX3uoSSvEgIIQe7LZHP0KoXtVy6yaoAinAJDK6cl9aqumjOom bpNrco15Bi5fIvKArRVH1JjMAaXtoDj3c447hKfgflsAZ1Ur+f7ArnA7lCIeWGIIWV 4R2wQ3wvfqhWFhDqe3rPVTTs8IL6tnExORlHZxv0= Received: by simark.ca (Postfix) id 3AE641E047; Mon, 08 Sep 2025 20:50:26 -0400 (EDT) Message-ID: <09056576-0c5b-4d55-b016-583e5e05c57e@simark.ca> Date: Mon, 8 Sep 2025 20:50:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/7] Boolify line-program.c To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250907-breakpoint-cu-expand-v1-0-dd2beef9d475@tromey.com> <20250907-breakpoint-cu-expand-v1-3-dd2beef9d475@tromey.com> <445303b8-f7e3-47f8-a67b-588ad3a13a6f@simark.ca> <871pogih7j.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <871pogih7j.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-09-08 20:48, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> On 9/7/25 3:29 PM, Tom Tromey wrote: >>> This changes some code in line-program.c to use bool rather than int. > > Simon> At the same time, I think you could fix the divergent intro comments > Simon> (one in the header, one in the source file). > > I fixed the appended but the comment in the header looks correct to me? > Anyway if you can point out what is wrong I will fix it. > > Tom The actual intro comment should be in the header, with the usual /* See ... */ in the source file. It looks like the comments diverged a bit, when that happens I try to pick the best of both. For instance, it looks like the comment in the header doesn't have the "Return non-zero if..." part. Simon