From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aWwiDv5bEmmr0jMAWB0awg (envelope-from ) for ; Mon, 10 Nov 2025 16:41:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1762810878; bh=XP7rwh7BxCT7BfwL0mBz1RExny8FXxjv1oFzw2CJkMo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=VC8QNW8yieAbFz8lw+J15DZgsISB/Xm3jo8/kMS6f+7ZCtt15GxxyHLPuXx68Er5Q HZKfUzrQwxLwmleJcfC1X1e1pCT4YPGSgjrDuui3IncKyspgIGSGU4V52BPdVxh3zY 7HbvP2FlmKobQN+d2aiofgRpTn6JQqcgi6Td3b4s= Received: by simark.ca (Postfix, from userid 112) id 357F71E0B8; Mon, 10 Nov 2025 16:41:18 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=S1UNwJC0; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C4F151E04C for ; Mon, 10 Nov 2025 16:41:17 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2E0F33858C53 for ; Mon, 10 Nov 2025 21:41:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2E0F33858C53 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=S1UNwJC0 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 086703858C54; Mon, 10 Nov 2025 21:38:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 086703858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 086703858C54 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762810706; cv=none; b=HTpdAOiAFvmcckyV37Xx0AEpR+ebfN/KNJMcvwxc9yzWSufQMx5VBSdxHfHZwfxDnbwFJI6xG+kdpjvVVC9jt6mhhzDkLwE39P/UzBM9Xe5qz9BI8/tofjg6KFT0NoQ1s2KGZ/IALOOv8boppUVBEeEoJVeYuqqts/1kYc5QiXo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762810706; c=relaxed/simple; bh=XP7rwh7BxCT7BfwL0mBz1RExny8FXxjv1oFzw2CJkMo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=pLDvjwJaIUyUunM0uUoWFigLSiDFEjP9gM/N+gqZv7o2LYM5vdqZFuZNQkG+swV/FfpWjdpz8B0KH6OU87Jex8rjfmLj/SOmySSZAl8r41wcRDw9twrXcjAX+HxAPdNa4MD0gHrXL4ch1L2Q+tA2ejOxeWXItO6gLRbSFGDxP0o= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 086703858C54 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1762810705; bh=XP7rwh7BxCT7BfwL0mBz1RExny8FXxjv1oFzw2CJkMo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=S1UNwJC0WqQcKn7X3wZ3GwsYmWzWtufS+SoSO+MmIsR1wSzu9FF9DxlhZIK2AarV0 yda460JZha07JDZZ2vNSrYcnrjYXGvrHJs4lG1zv6mK5CzQe56DQHcT8gKA8b6QC9X 4ehfzhCc+cfqpJC7QdDUJHlaWOmteTjkf+yo4LpU= Received: by simark.ca (Postfix) id 69CB21E04C; Mon, 10 Nov 2025 16:38:25 -0500 (EST) Message-ID: <08dd0dbb-b105-4039-b81e-4569b3a44065@simark.ca> Date: Mon, 10 Nov 2025 16:38:25 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] gdb/hppa: guess g packet size To: Sven Schnelle Cc: gdb-patches@sourceware.org, Helge Deller , John David Anglin , binutils@sourceware.org References: <20251110210717.152087-1-svens@stackframe.org> <87zf8th8s7.fsf@stackframe.org> Content-Language: fr From: Simon Marchi In-Reply-To: <87zf8th8s7.fsf@stackframe.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 11/10/25 4:34 PM, Sven Schnelle wrote: > Simon Marchi writes: > >>> + warning (_("target returned a target description this gdb doesn't " >>> + "support for the HP/PA architecture")); >> >> Good idea to put out a warning. I would suggesting some minor changes >> to the message: >> >> warning (_("The target returned a target description but this gdb " >> "doesn't support target descriptions for the HP/PA >> "architecture")); >> >> Just thinking out loud: it would actually be nice to have this warning >> for all architectures that don't support target descriptions, if there >> was a way to put it at a single common place. >> >> Other than that, the patch looks fine. >> >> Approved-By: Simon Marchi >> >> Do you have push access or would you like me to push the patch on your >> behalf (with the modification proposed above)? > > I don't have push acess - would appreciate if you could adjust the > message and push it. Done, thanks. I even extended the message to: warning (_("The target returned a target description but this GDB " "doesn't support target descriptions for the HP/PA" "architecture. Assuming standard 32-bit register" "layout.")); Simon