From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29021 invoked by alias); 17 Jun 2003 16:04:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28860 invoked from network); 17 Jun 2003 16:04:23 -0000 Received: from unknown (HELO hub.ott.qnx.com) (209.226.137.76) by sources.redhat.com with SMTP; 17 Jun 2003 16:04:23 -0000 Received: from smtp.ott.qnx.com (smtp.ott.qnx.com [10.0.2.158]) by hub.ott.qnx.com (8.9.3p2/8.9.3) with ESMTP id LAA15245; Tue, 17 Jun 2003 11:57:44 -0400 Received: from catdog ([10.4.2.2]) by smtp.ott.qnx.com (8.8.8/8.6.12) with SMTP id MAA12907; Tue, 17 Jun 2003 12:04:22 -0400 Message-ID: <08d801c334ea$23fd99c0$0202040a@catdog> From: "Kris Warkentin" To: "Daniel Jacobowitz" Cc: "Gdb-Patches@Sources.Redhat.Com" References: <08c201c334e6$ccb8c750$0202040a@catdog> <20030617155147.GA25280@nevyn.them.org> Subject: Re: [Patch] arch recognition fix for osabi.c Date: Tue, 17 Jun 2003 16:04:00 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165 X-SW-Source: 2003-06/txt/msg00564.txt.bz2 > > Changelog: > > * osabi.c (gdbarch_init_osabi): Just check arch for compatability rather > > identicality. > > Your mailer is eating indentation again... Yeah. It's fine in the editor - it's the cut and paste to Outlook that buggers it. > This half I'm not convinced by. From our previous exchange I don't > think you've fully justified it. Not approved without more discussion. Okay. Let's use mips as an example. The 'compatible' check returns true if they have the same arch (ie. bfd_arch_mips). There will be many different values for the arch_info pointer, all with bfd_arch_mips and various other pieces of info such as which machine type (10k, 4300, etc.) of mips it is. The handler was registered for bfd_arch_mips with no other information. In the absence of the ABILITY to do anything smarter, we have to assume that if the handler is for bfd_arch_mips, it should be run. As it stands, if the bfd reads a file and says 'this is a tx3900' or some such, the pointers won't be the same and my backend init_abi won't be run even though I want it to run for all mips targets. > > (generic_elf_osabi_sniff_abi_tag_sections): Add check for QNX Neutrino > > binaries. > > This bit looks fine, except for two things: you've missed the coding > standards by four space characters (before left parens), and your > "safety first" check overruns the buffer (missing +1 in the alloca). Doh! Not very safe was it? Sorry about that. Fixed. cheers, Kris