From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id fmG4CxrBEGbEJSUAWB0awg (envelope-from ) for ; Fri, 05 Apr 2024 23:27:22 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=aoShwY8+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 157521E0C0; Fri, 5 Apr 2024 23:27:22 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C48C91E092 for ; Fri, 5 Apr 2024 23:27:19 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ED58B3858282 for ; Sat, 6 Apr 2024 03:27:18 +0000 (GMT) Received: from YT3PR01CU008.outbound.protection.outlook.com (mail-canadacentralazon11020003.outbound.protection.outlook.com [52.101.189.3]) by sourceware.org (Postfix) with ESMTPS id C8DE23858D1E; Sat, 6 Apr 2024 03:26:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C8DE23858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C8DE23858D1E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=52.101.189.3 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712374019; cv=pass; b=no2cRbks2XShN7rI7fed8wIB8TZIFFfn5PNUAm6y/kIKdIV79anN8t97PxMipLfmnB8zRyMRavEb9re3+CKD/zIQI0QUP39c3YI6edP45l+MwqMANP6MrcTbbnNwAeUXnLKzpr1Yg0awUAFrFGuqNXHC9wqpet4ANTQcz/Qc2pw= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712374019; c=relaxed/simple; bh=vM4LDUV+a5XQSdgKus85XrAEYbJBujWGAgZE+5pu5tY=; h=DKIM-Signature:Message-ID:Date:Subject:From:To:MIME-Version; b=Cu00vxj/ZvFDo8CffFUmqfNVH6iIQKtpxxBnrcJnPaQ4ieUvUKm5/58PVs40ogCclaYSA+qWyrxqx7opE7kDRtE95X9KLxa1Yxywp5xLvManvpQobPBqZa1KVvgzzrV7OFLGwfaW3joovIgHLtgvn3EzTWYz69NIBNBky/C/UFE= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l9TcF1W30iVa1RKOtjwzb/dQGUKotzE3f1KAo79vwoJpdeFoNMDQQMLXU1Xn44etn64AakgWp37P8FqzFfxitL5fNANmYNHGGeBDQaSko+sR5/+62MPfjjBpoTiaryvpkdQ5ioQOgPO6sdO5xqZEeElDjCrfANBnPF6+IGYIVQ+FFwCvcz5Z0ENU5TYPDi3tNyRSoyb6p5Mb5NAbv/eiZkjlBGfwgElkYT78/jpsEc/xmYt9HAhLlXB8WtPR36N2zbyId65i29IbVA4hlVrAOqk/ptXaeda3pZEGU4TtoL/uMISvbsPeHaw8A0DECeNDljywm7/W93NUscBFkHgp2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wl8xo8auwlmecKVWZ8tw5N+28Pl/PN3OmPtsYmJWStE=; b=navZ1JXZwLMjc7ljW6pt8zULCe4BetfaprQY/0Fc18/8mDKG3rXUpGrEmKiL1Yiv12pJT1plbbxfa3QAZo8glEFugdd8k39zP5rpUHlvpULAqS8b1kge9vqUnKrtX6Y/IY1joYGnVtYy8ALsI/i+8WiLrvq0083SKKSrMDQGTYk41dqlk5FuIph2HRNrvCaJ/5ndKPFhXeccPOBRwbP2C96kxyJW5nXParT+BqiRh5rPhHBd7kvv0ksaJUkijWmOs+UndsisF+L1BXHOZUJQniFebE/KESLmqKcSZDBH+qvDd+3HrAL+iU/4UiSJNqEFc+PRuNA7jnX5tms6hNuBTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wl8xo8auwlmecKVWZ8tw5N+28Pl/PN3OmPtsYmJWStE=; b=aoShwY8+EkbW/jw7ncjcAR2NQgydRk1NWaOdisubNFVL1nM0bUJSeVQXtXsfwZnniiC7DKxRVuhcOoaCVpHr6G31Gm9pHf2oDO3xskucjFewAnDpKlNZ0LPkOuNl1XMETRH1nZ+y+HdRayrBabJMOu0hMfLw8POuKUPlBznavLDgGF8bt+6hEB3WFDagCpDbjgC2IYdrCk/MgxXDUGifDZeZMjMGCPqQEvBAbASN8hgoHlWtE3A6ma5id7VZy95UXQvg+C7cz5QGOKz5xkXLIKykJYUhz/Eo76Hwq9EbVv607zAKbMGwaromTTanaUayQMxaAxiOFOjuC+nRIOtauw== Received: from YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2e::17) by YQXPR01MB5318.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.26; Sat, 6 Apr 2024 03:26:55 +0000 Received: from YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM ([fe80::3f0e:8077:5724:81b1]) by YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM ([fe80::3f0e:8077:5724:81b1%5]) with mapi id 15.20.7452.019; Sat, 6 Apr 2024 03:26:55 +0000 Message-ID: <08ccf2e8-6494-4bb4-bcf3-51bedf24ac24@efficios.com> Date: Fri, 5 Apr 2024 23:26:53 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: ignore -Wregister instead of -Wdeprecated-register From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org, binutils@sourceware.org References: <20240311160715.90270-1-simon.marchi@efficios.com> <878r2opski.fsf@tromey.com> <0780826d-4649-45e8-b056-dcae2a513bb1@efficios.com> Content-Language: en-US In-Reply-To: <0780826d-4649-45e8-b056-dcae2a513bb1@efficios.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBP288CA0020.CANP288.PROD.OUTLOOK.COM (2603:10b6:c01:6a::24) To YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5520:EE_|YQXPR01MB5318:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7zXtjcRQt61OplZMHOa06eT/ywahSNtbAWsO2x0bu7GzTBfhgUsTSY9xHlYCVnsLc8hgqxhnX20Id7IsmmP7zw3QOE/oQpCOuedAHkPzBpW8Hh67XQ0e0lvxjKmulZrf1AH3ATMdViCJ605zgAaie4/cNCZ3EUnlham0e/Gc45eo2dM3MqZMM7b2BNuNcUDm1jEM1np4yj1xgaZwEpaMuI/I+Sh4/gZzDU9EhTVCXR4Hhcmf8q77mTiOeG1iLxw6KinqzLb1QWKog+WZM/EBO4pGuP7ZWPduK5Tu7OTSXBBFtohEcKDUIcnJAvOi4Dg/WSkOCqXZpqOvqWNrhSOI8tmfjwyN74W2PCveIz3qHWLvEvO0YsEYmyOq2sPw93lEqChX/VSJgC5Ko5sVGtgNqT7z5t6eSp0jHDiHwSOBHTUrzWapXt5MDH/8AyyopMXDm5q4UULmIlmFAbccv5sDV5o3LMzd+EhuWXhx1uI1muVQl/MUDaJUZ5uMUKpgEESKKo5DJrdcLVxhnxhvYT+N6Xd+ZeOh+KKssq1ElnvivJym4IsgQ5OfvaYvbS95CoLl6dvWJOcF4WC4O3LKh9JJ1s5Ccf8xnQf/OKV/4KPw4FSWP3tH6nktYnx8Fhpteg2vcPAAaJC5YPvGBMGuhFBP0wcf7fbL0qqc/oClMg4MB1Y= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3pLUmp5Qnp5a1o5clZ1enBobFR6aHRtdTNVSDlnMFgwbkZmRGJNQ3ZiSFY2?= =?utf-8?B?aXRZQzRwOG9FT2hzVUNlN2xaWmNzVVo2S3gvbDNYZGtmQ0kyUEZlQWp6RXFV?= =?utf-8?B?QUZvd3VVQlBOcTduOTc3Y0xBTXZDckxScXFjalJhSng1d3NXeGNMVitkaVFo?= =?utf-8?B?S3hSMVRMZ1NQVnZnbDlDMCtQN21sSHd4MUNGb2MwWXpoNVViMDBKOFJLRzE0?= =?utf-8?B?MXlEWCtXOG94eGRuSGpKNyt5ZkFTdUlhYlB2dmRoRmZCSVNRRFo4dFZ4VHZh?= =?utf-8?B?SjNIL2RNS24xS1NJaDBlK3NMTno1UFh6SmtHUGpEYi9oaVpqMmRDVDVXN0xR?= =?utf-8?B?L3I3K1NwZThsUlJ0NkV1L1Y1R1AzSlc4YStOWEJ2UHhwQ3UzTzhyQm5QWnZ4?= =?utf-8?B?dEZFZTJ1TytXVWZGdE5WdFBnUW1wR3dVMnZhN0ZHM2NtWWNiby85VmI5ZEtl?= =?utf-8?B?LzlkY0RtckJlbUFJZWRzcnozckx3M3c0NDlQeFN6L2hqMldvR3VGWUpGQnB3?= =?utf-8?B?dFlvR1lheHlvMmVES3BWQ2NadDh3cXFaY3pCNkJkT01oblFvZktreC9JYktz?= =?utf-8?B?Z2JNUFdBRjYwN2xLNFM4NGUxOUlKRDg2RDJtbldTcS9hM0VqNHc5QXYzeFZ1?= =?utf-8?B?ZW1OT1ZIM091UVpHelovN0hSMmJheDlCaXdnVGlBbDBoN3E1cTVkL1ZmZlZ5?= =?utf-8?B?MmxTaHJCdnR6QVZHZVhQcnhIKzhBcnpxVEZvTzZ1bXRRM0tTSmJUWWxGWVIy?= =?utf-8?B?bDFITWl2MjBwY3hIcEVIb09pMmV4V2VBdG1qNDBPNVF3a2ZNdkVOYXdEaTF3?= =?utf-8?B?eUowZ00zc2kwMUtDeGJldXZPbnRVQkw2K0k5Z2NNYytIUXdJOElHMFcxUG5t?= =?utf-8?B?S1NTL29iS2tlOVB2b1RyTXNOZytoZFNvSFNUZDNYc25yU2wzSWJMVjU2S1RB?= =?utf-8?B?b3ZmM25zb1ZQU001bEdZeFdIZmhGckZmVmpmcFdUcXpPSGQ5U2Z4c2Z3ZWhM?= =?utf-8?B?YzBCbWVxRDlnQXk1SDlRbkpQK1hicWxDR3lrS1NzL2hkV2JWRXF3Sk9LakRH?= =?utf-8?B?T2VyM1pQOVBaRTA1RE54Vlg3ZlR5QUxHdkxSdVE2M2l5WHA2WlB2YlU5czZz?= =?utf-8?B?c21RV3JIaE43aGRWdWhBYitaaVp1c0JKc21kdTRRc2dIdWRwZkJ4K1p5T3di?= =?utf-8?B?U2hXMlRwUDdtakdkbFVpc2dhR1FTNG5NN1R0ZEdEeit2N3hVTGd1UW1QelhP?= =?utf-8?B?N3JuekJhSVJHTVNMQjFPOUp3cjJhMVBwTGsrTzFmY1lyTGl3aXE3Q3ZiWURW?= =?utf-8?B?QU8xdWRuSlp2SThpZmEwck5Vdk45MVB0ZVhtL0paWGdKOVJ2bXdRdSt3VEk5?= =?utf-8?B?b1J1ZkVranFSR0ZDWHZ6eHBwSTIrR0NoQzd4eWxiSHBxdVNYN2lkRnNwSm5a?= =?utf-8?B?N3hOa3E0bDRhUWxTb3ZHdWZuRXBsNnEzWlE2RTNXNk5jOTdVOXlzcG03L2k1?= =?utf-8?B?Z1o3eVlraDhPRzg0Q1hTVnhxQjROOFBOSWtzL1ZNdmVEQlphc2pxSFZlaDly?= =?utf-8?B?MUhZaU1HTzFKeU0xOHF2WmRUU0JZaWVSNC96TjVlWnhaV0p1Y29EWGx6Nit3?= =?utf-8?B?UFdKZHBoQ2VEQ0tTelNLT2I0QnpSOTBPQXpJWVpsNkJzMnkvUFZXd3RLVURa?= =?utf-8?B?WVFxbGsvd1Q5d2h6cEpTdkNZcUlMTjZ1bXhQQnRESkRseXZ3RXpmQUY3eUFS?= =?utf-8?B?Tm5OcDR5SFNrZGR1YklnNzRCRmV2RUp2dnlTV3RxRXRyWEl5K2JLZW1pY3hJ?= =?utf-8?B?SklnUmNOUXVZSHlaMk1EbG9UYVk3QkJ6MVJiN1RTeXBMQjhVWFNhWksyelBm?= =?utf-8?B?WVhhVWdBU2k2NDdiSGE5RjVza0xhWWk1RUJWNjd2aEdjQnlIZ1BCNmZpTEp5?= =?utf-8?B?RlRTRG9SZE81WGROT1ZwYzhSZXpCT3I3c0tNUlBhMU01MkdmT3d5Z3NEaEJn?= =?utf-8?B?QlFNYTNwWnFaRFRKUzJIL3libSsxMWJ4WGplemxSR0d0Rk5FanlwZ1V3Y3pF?= =?utf-8?B?UmZ2Q0ZOazBjVEl6Nlg3VHZsdVZGK21nMjhlMjVzMmlncjluUkR2clR2aUpz?= =?utf-8?Q?FX3SeMQBVVFaElPZyolNAkNUD?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: f046c2b5-92db-4483-76f8-08dc55e9689e X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2024 03:26:55.2479 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qpsis1wmpvYBnCrDIFFzGvsUsNmH2syo9+UrSwU5ay79bFSAIWYdTR7NfSgw99yh8VyFqFOF5tKdCcghcZ1Clg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQXPR01MB5318 X-Spam-Status: No, score=-3032.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 2024-03-11 13:51, Simon Marchi wrote: > On 3/11/24 13:49, Tom Tromey wrote: >>>>>>> "Simon" == Simon Marchi writes: >> >> Simon> In ada-lex.l, we already use `DIAGNOSTIC_IGNORE_DEPRECATED_REGISTER`, >> Simon> which for Clang translates to ignoring `-Wdeprecated-register` [1]. I think >> Simon> that was produced when compiling as C++11, but now that we always compile as >> Simon> C++17, Clang produces a `-Wregister` error [2]. >> >> Can we just '#define register' in this file or somewhere nearby? > > We probably can, but ignoring the diagnostic seems safer and less hacky > to me. > > Simon Just stumbled on this. Are you ok with the current patch, or would you really prefer the #define approach? Simon